Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openseadragon module: replace version with configurable variable #1710

Open
bseeger opened this issue Nov 20, 2020 · 1 comment
Open

Openseadragon module: replace version with configurable variable #1710

bseeger opened this issue Nov 20, 2020 · 1 comment
Labels
Type: enhancement Identifies work on an enhancement to the Islandora codebase

Comments

@bseeger
Copy link
Member

bseeger commented Nov 20, 2020

The OpenSeadragon (OSD) module code has the version of the OSD to use hard-coded in a few places. It's tricky to make it a configurable variable, but we should do that at some point.

Example: https://github.com/Islandora/openseadragon/blob/8.x-1.x/openseadragon.module#L150

@whikloj
Copy link
Member

whikloj commented Nov 25, 2020

Forgive my ignorance, I've been out of Islandora 8 for a bit. It appears that there is the OSD config already loaded in the method you linked to. Could you add a field there and pull it when you make that array? Or is the tricky bit the validation of the version?

@kstapelfeldt kstapelfeldt added Type: enhancement Identifies work on an enhancement to the Islandora codebase and removed enhancement labels Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement Identifies work on an enhancement to the Islandora codebase
Projects
Development

No branches or pull requests

3 participants