Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carapace is not D9 ready #1733

Closed
dannylamb opened this issue Dec 7, 2020 · 6 comments
Closed

Carapace is not D9 ready #1733

dannylamb opened this issue Dec 7, 2020 · 6 comments
Assignees

Comments

@dannylamb
Copy link
Contributor

dannylamb commented Dec 7, 2020

It depends on Adaptivetheme, which looks like it's not going to be D9 ready. If we want to go with D9 quickly, since no core functionality relies on it, we should ship with Olivero and Claro (the new Drupal default themes), until we sort out what to do with a community theme.

To accomplish this, we'll need to remove carapace from any composer.json that requires it and also update the config in config/optional in islandora_defaults to use the standard D9 themes.

@alxp
Copy link
Contributor

alxp commented Dec 7, 2020

+1 for Claro which has many accessibility improvements over Seven as an admin theme.

@dflitner
Copy link

dflitner commented Dec 7, 2020

Not saying that we should continue with Adaptive Theme since I'm not confident in its continued viability but someone forked it since the original maintainer has gone AWOL. https://www.drupal.org/project/at_theme.

I agree that a sub-theme or config on Olivero is a good way to go until/if we pick a new base theme.

@seth-shaw-unlv
Copy link
Contributor

I know there is a lot of love for Olivero and Claro, but Bartik and Seven are still the default themes enabled on a stock Drupal 9 Standard Profile install. Should we shift our defaults to Bartik and Seven (in line with the current Drupal defaults) or should we be explicitly setting Olivero and Claro as the default themes in our build tools (playbook and isle)?

@seth-shaw-unlv
Copy link
Contributor

E.g. for the playbook we would either drop this section to get bartik, or update it to set Olivero.

For isle-dc, 🤷‍♂️. Presumably we need a new image on dockerhub? I'm not seeing anywhere to set this in the isle-dc github repo.

@manez
Copy link
Member

manez commented Dec 8, 2020

For Olivero and Claro, they still just "future defaults" based on Drupal Strategic Initiatives for a new admin them (https://www.drupal.org/about/strategic-initiatives/admin-ui-js) and base theme (https://www.drupal.org/about/strategic-initiatives/olivero), and I don't think we want to get too far ahead of the curve on adopting something that Drupal hasn't made official yet, but the focus on accessibility in both themes is really appealing.

@elizoller
Copy link
Member

islandora-deprecated/carapace#25 with copied work from islandora-deprecated/carapace#24 thanks @nigelgbanks ! gives us carapace support by depending on a d9 ready fork of adaptive theme
although it may not be the default theme anymore, this support at least allows sites using carapace to keep up to date and run on d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants