Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

field_genre in islandora_defaults points to an undefined "genre" taxonomy #1818

Open
mdlincoln opened this issue May 7, 2021 · 12 comments
Open
Labels
Subject: Docker ISLE Related to the maintenance and upkeep associated with ISLE’s docker image. Type: question asks for support (asks a question)

Comments

@mdlincoln
Copy link
Contributor

mdlincoln commented May 7, 2021

As far as I can tell, when field_genre was added to Islandora defaults, it referenced a genre taxonomy. But the taxonomy itself isn't defined in that module. So when we install the module now, we get the field but no taxonomy with it.

@mdlincoln
Copy link
Contributor Author

I see now this shows up in https://github.com/Islandora/controlled_access_terms/tree/8.x-1.1/modules/controlled_access_terms_defaults/config/install but for some reason it's not getting installed when we try to build ISLE?

@seth-shaw-unlv
Copy link
Contributor

Perhaps you are pulling the 1.0.0 tag?

@seth-shaw-unlv
Copy link
Contributor

Or perhaps you are not enabling the controlled_access_terms_defaults submodule?

@mdlincoln
Copy link
Contributor Author

I can see the genre taxonomy definition yml file at codebase/web/modules/contrib/controlled_access_terms/modules/controlled_access_terms_defaults/config/install/taxonomy.vocabulary.genre.yml

Trying to run drush en controlled_access_terms or drush en controlled_access_terms_defaults just returns a message that both modules are already enabled, and doesn't seem to add the Genre taxonomy.

@hachacha
Copy link

I just tried uninstalling and reinstalling then running the drush cim to see what the config looks like and it's suggesting that this field should be deleted.
So does that imply that it's always being deleted when trying to install? Should it be exported first?

@seth-shaw-unlv
Copy link
Contributor

Uninstalling controlled_access_terms_defaults won't purge the configs. (It is designed to be enabled once and then disabled, leaving the configs behind, like search_api_solr_defaults.) The best way to manage missing configs is to export your configs (drush cex -y), copy the missing configs into config/sync, and then re-importing them (drush cim -y).

@kspurgin
Copy link
Contributor

Same issue @mdlincoln is reporting was in the sandbox @dannylamb set up for MIG use.

I didn't realize the genre taxonomy was set up outside islandora_defaults, so I set up that taxonomy in islandora_defaults in the config changes that came out of the MIG sprint.

Danny has those config changes, but they haven't been merged anywhere. But just noting that there is now a duplicate genre taxonomy defined in my changes. There were a couple other entity reference fields that were supposed to be pulling from a taxonomy that didn't exist in the sandbox, so I defined those taxonomies and pointed the fields at them. Might be worth checking if those aren't also defined in controlled_access_terms

@seth-shaw-unlv
Copy link
Contributor

I just spun up the islandora-playbook using the ubuntu/focal64 base box and the genre vocabulary is present... so something is happening with the installer if the genre vocabulary is missing in your build.

@kspurgin
Copy link
Contributor

My build was the sandbox Danny spun up for MIG. 🤷🏻

@seth-shaw-unlv
Copy link
Contributor

@dannylamb, what did you use to spin up the MIG box? The islandora/8 base box or isle_dc?

@mdlincoln, did you use the islandora-playbook or isle_dc for your site? If isle_dc, which make option did you use?

@hachacha
Copy link

@seth-shaw-unlv I work with @mdlincoln
We are using isle-dc. We used the make local option after creating the codebase from the make-local-from-demo branch.
I had tried using the islandora-sandbox as the codebase and then using make local but ran in to some issues with the install -- I can speak to that more in a different issue if appropriate

@seth-shaw-unlv
Copy link
Contributor

I'm not very familiar with isle_dc and I'm in a training most of today and the next two days, so I'm probably not the best person to move forward with this. I put out a call on the isle channel of the Islandora Slack, so hopefully someone will be able to give it a look.

@kstapelfeldt kstapelfeldt added Subject: Docker ISLE Related to the maintenance and upkeep associated with ISLE’s docker image. Type: question asks for support (asks a question) and removed ISLE labels Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Subject: Docker ISLE Related to the maintenance and upkeep associated with ISLE’s docker image. Type: question asks for support (asks a question)
Projects
Development

No branches or pull requests

5 participants