Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: unable to change paged content child weights if all values are set to 1. #2065

Closed
antbrown opened this issue Mar 18, 2022 · 1 comment
Closed

Comments

@antbrown
Copy link

If you accidentally set all weights to 1 using the IntegerWeightSelector, it is then impossible to change the value to anything other than 1.

node-field-weight-ui-options

node-field-weight-db-values

I think this happens because https://github.com/Islandora/islandora/blob/2.x/src/Plugin/views/field/IntegerWeightSelector.php#L54 only populates all possible values for the select element if there is a blank value returned from $this->getValue($row).

I think it should maybe populate all possible values when the number of options is less than the total number of rows returned by the view.

@jordandukart
Copy link
Member

Merged in Islandora/islandora#863.

@jordandukart jordandukart removed their assignment Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants