Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLAW-JSONLD needs cleanup #542

Closed
DiegoPino opened this issue Feb 24, 2017 · 5 comments
Closed

CLAW-JSONLD needs cleanup #542

DiegoPino opened this issue Feb 24, 2017 · 5 comments

Comments

@DiegoPino
Copy link
Contributor

DiegoPino commented Feb 24, 2017

http://github.com/islandora-claw/claw-jsonld needs some love (was born in a loving family but never got proper education)

  1. Drupal coding standards
  2. Remove classes that were implemented later somewhere else (context!)
  3. Make proper Unit and Kernel Tests.
  4. Make deserializer part a reality so POST, PUT and PATCH can rely on that instead of building its own code.

Needed so #540 can be applied (and pass) on this module

@DiegoPino
Copy link
Contributor Author

@ruebot @jonathangreenCoding Standards are done in Islandora/jsonld#5 , but now Tests are badly needed. Since those need to be made from scratch I did not fix coding standards on the existing ones.
If anyone can do them faster and better than me (release mode, so slow) it would be extremely welcome. If not will take me some days but will get there. Thanks

@jonathangreen
Copy link
Contributor

This is awesome @DiegoPino! Thanks for doing the coding standards cleanup. I don't have any tips for building tests, but @dannylamb might.

My next plan is to figure out the java part of #520, but if this still needs tests after that I can do them. Just may take me a bit to get to it as well.

@DiegoPino
Copy link
Contributor Author

Ok, we have following pull-requests merged
Islandora/jsonld#5
Islandora/jsonld#6
Islandora/jsonld#7
are done. Next proper tests. Thanks!

@ruebot
Copy link
Member

ruebot commented Mar 29, 2017

More coding standards PRs:

@ruebot
Copy link
Member

ruebot commented Mar 29, 2017

@DiegoPino can you close this issue because the scope it pretty big on it, create additional issues that are more fleshed out for the remaining items originally proposed, and link those to existing PRs & issues?

  • Remove classes that were implemented later somewhere else (context!)
  • Make proper Unit and Kernel Tests.
  • Make deserializer part a reality so POST, PUT and PATCH can rely on that instead of building its own code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants