-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not able to build using Nodejs 12 #123
Comments
Seems related to this atom/node-spellchecker#112 |
Yeah, I link it in the low quality issue as a newer version of chrome might solve that problem. Unfortunately, that breaks the spellchecker and the other module that we are using. Not sure if we can call it a bug as its not really a bug in our app. It does block us from been able to move to electron 5. |
I did remove the "bug" label as might be misleading. We will need also to contribute in here for the update... or create a fork from that project an integrate the spellchecker fix. |
+1 I can confirm this also |
I have removed the need to use electron-spell-check-provider and updated the packages so this should now be close. I just done a build with node v12.4.0 #152 |
Describe the bug
Trying to build using nodejs 12 shows an error and stop the build
To Reproduce
Steps to reproduce the behavior:
yarn install
Expected behavior
Build should work
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: