-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Charge Parameter Discrepancies between LigParGen Server and LigParGen v2.1 #31
Comments
Have you tried locally with BOSS v.5.1? |
For BOSS v.5.1 (April 2024 Release), the output appears to be the same as BOSS v.5.0 for the case tested above, i.e., my .XML file still looks different than the server output. Is the server using an older version of BOSS? If, say I use a error-prone "DUMMY" SMILES string as an input for the server, I get the following error: export BOSSdir=/var/www/html/ligpargen/apps/boss-4.9;/var/www/html/ligpargen/apps/anaconda2/bin/python2.7 /var/www/html/ligpargen/apps/ligpargenCode/Converter.py -s 'DUMMY' -r UNK -o 0 -c 0 > /tmp/errorServer.log This seems to suggest the LigParGen server is currently using BOSS v.4.9. This might explain the discrepancy since v.4.9 (Released Jan. 2013) would not include the parameter changes in OPLS/2020. |
Hey, Yes, the server was initially released in 2017 and uses BOSS4.9. The GitHub version of LigParGen has since been updated and rewritten from scratch to address compatibility issues with newer Linux distributions and to align with the latest BOSS version. |
Is there any comment on which parameters are "correct" and/or suggested use given the discrepancy, i.e., should users revert to the GitHub version when possible? Thanks so much!! |
Hey Shehan, I recommend using this version, as it includes the latest OPLS updates. There is not a “correct” or “incorrect” version -both have been reliable over time, though the latest version should ideally offer improved parameters. To my knowledge, there are no plans to update the server. In any case, for many molecules, the parameters will remain the same. By the way, have you added the BOSS executable to the Docker container? I am unsure if that is allowed under the BOSS license. I won’t be able to accept any commit unless I am completely certain it complies with the software license. Best |
I see, in that case, I won't use the BOSS executable through Docker to err on the side of caution. I'm not so sure if there is a work around at the moment, however. |
Hi,
I'm creating a new issue similar to #9--using LigParGen (LigParGen v2.1, BOSS v5.0) and comparing it to the online server, I get a case where the charges are different in the resulting OpenMM XML files. For example, if I run...
ligpargen -n TMP -p TMP -r TMP -c +1 -o 3 -cgen CM1A -s 'C[P+](C)(C)C'
the
<NonBondedForce>
(and<AtomTypes>
section, for reference) from theTMP.openmm.xml
looks likewhereas if I input the exact same smiles string (and optimization and charge model settings) into the server, the resulting xml file looks like
You can see that for the phosphorus atom, the charge differs by ~0.4 e, 2.535500 from the server vs 2.128122 from the code. For the case of
C[P+](C)(C)C
, I did additionally get a runtime warningUFFTYPER: Unrecognized charge state for atom: 1
, which seems to be an rdkit issue. This isn't necessarily the source of the inconsistency because I also tried testingC[N+](C)(C)C
which suppresses the warning but results in inconsistent xml files. It would be very helpful to know if (1) this is reproducible for others and (2) where the discrepancy is coming from, thanks!The text was updated successfully, but these errors were encountered: