Genericize Content to allow AsRef<[Operation]> #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was just
Vec<Operation>
before, which may be the most common use-case and is also required for parsing, since allocation is necessary.When creating a document allocating a
Vec
perContent
may not be necessary though, so for that use-case allowing anyAsRef<[Operation]>
, like just a slice, is convenient.Example:
The operands for
Operation
still requireVec
. If theOperation
struct were to be replaced with an enum as suggested in #109 (with an additionalCustom { operation: AsRef<str>, operands: AsRef<[Object]> }
) that would become unnecessary though. If you like the idea I'd be happy to make a PR for that as well.