AsyncReader #265
Merged
AsyncReader #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After spending more than a few minutes with the code I removed the AsyncReader then shoved the async reading into a feature-gated Document implementation. Much cleaner that way and without a ton of code duplication. There's also an addition of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR's goal is to introduce an AsyncReader via Tokio. There's a lot of code duplication due to my not being familiar with the pattern used here, but it's all feature-gated by "async". The examples are 99% copies, we could throw them in an async folder to separate? Don't mind to make changes re: code duplication, suggestions welcome.