Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide controlBox and border feature #18

Closed
nguyenvanbien95 opened this issue Jul 21, 2020 · 8 comments
Closed

Hide controlBox and border feature #18

nguyenvanbien95 opened this issue Jul 21, 2020 · 8 comments

Comments

@nguyenvanbien95
Copy link

Describe the feature you'd like
A clear and concise description of the feature you'd like to have.
I want to remove border and control box.

Reason for this feature request
A clear and concise description of the reason(s) for this feature request.
In some case, application is developed for Rasberry Pi. Pi has a touch monitor, and my user don't be closed program.

@JBildstein
Copy link
Owner

I'll look into it. I think all OS support it but I need to check the specific APIs.

Do you actually need windows without borders or do you need fullscreen windows?

@nguyenvanbien95
Copy link
Author

Yeah, I actually need fullscreen windows.

@bddckr
Copy link
Contributor

bddckr commented Jul 30, 2020

If those APIs allow to toggle this behavior, that would be great, too! I can see the need to do a regular fullscreen view for video playing and the likes.

@nguyenvanbien95
Copy link
Author

If those APIs allow to toggle this behavior, that would be great, too! I can see the need to do a regular fullscreen view for video playing and the likes.
Hey @bddckr
Do you play video of youtube on webview on linux? My video have no sound. Can you help me?

@JBildstein
Copy link
Owner

sounds good! I wanted to improve the minimize/maximize behavior of windows for a while so that fits well into that.

@bddckr
Copy link
Contributor

bddckr commented Jul 30, 2020

@nguyenvanbien95 No I do not, and a separate issue is most likely better for that to get someone who can help 🤞

@nguyenvanbien95
Copy link
Author

@bddckr I had done that. Thank you.

@JBildstein
Copy link
Owner

It's implemented now. The Window class now contains:

  • the BorderStyle property to get borderless windows
  • EnterFullscreen and ExitFullscreen methods
  • Maximize and Unmaximize methods
  • Minimize and Unminimize methods

and the SetWindowState method has been removed.

This now matches how many OS native methods are implemented and allows more fine grained control over the sizing behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants