Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to allow tabbed pane separator to take full height #59

Closed
tanmatra opened this issue Feb 9, 2020 · 4 comments
Closed

Option to allow tabbed pane separator to take full height #59

tanmatra opened this issue Feb 9, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@tanmatra
Copy link

tanmatra commented Feb 9, 2020

It may look more "solid", and the latest IDEA is using this style for editor tabs.

image

It can be done simply enough, just by changing float offset in line 310 of FlatTabbedPaneUI to 0.

I can create pull request for it.

@smileatom
Copy link

PR submitted #62

@tanmatra
Copy link
Author

There is a typo:

FlatClientProperties.TABBED_PANE_TAB_SEPARATORS_FULL_HEIGHT = "JTabbedPane.tabSeparatorsFullHeight"

but in FlatTabbedPaneUI:

tabSeparatorsFullHeight = UIManager.getBoolean( "TabbedPane.tabSeparatorsFullHeight" );

@DevCharly
Copy link
Collaborator

@tanmatra thanks for the idea. smileatom's PR is now merged into master branch.

To try it out add the latest snapshot (https://github.com/JFormDesigner/FlatLaf#snapshots) to your dependencies and add following to your code (after installing FlatLaf):

UIManager.put( "TabbedPane.tabSeparatorsFullHeight", true );

A new release will be available in some days.

@DevCharly DevCharly added the enhancement New feature or request label Feb 11, 2020
@DevCharly
Copy link
Collaborator

released in 0.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants