Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make iconStyle a widget #6

Closed
chitgoks opened this issue Jun 13, 2020 · 2 comments
Closed

Make iconStyle a widget #6

chitgoks opened this issue Jun 13, 2020 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@chitgoks
Copy link

chitgoks commented Jun 13, 2020

This way, users can have the option to even tap the icon in the indicator

or im not sure how you would do this but considering there is already an indicator property which is a widget, perhaps a callback property so that users who want to use the default indicator will be able to execute call back code when that indicator widget is clicked.

@JHBitencourt JHBitencourt added the enhancement New feature or request label Jun 16, 2020
@JHBitencourt
Copy link
Owner

I don't think making IconStyle itself a Widget would be a good idea.

But a callback to add onTap functionality to the default indicator is definitely a good suggestion.
The question is if I should ignore it when a custom indicator is provided. Considering that this custom indicator may have its own onTap callback.

@JHBitencourt
Copy link
Owner

Since it is basically the same subject, I'll be closing this issue and keep track on #5 .

@JHBitencourt JHBitencourt added duplicate This issue or pull request already exists and removed enhancement New feature or request labels Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants