Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloadable compiled packages separately? #35

Open
bronius opened this issue Sep 26, 2020 · 2 comments
Open

Downloadable compiled packages separately? #35

bronius opened this issue Sep 26, 2020 · 2 comments

Comments

@bronius
Copy link

bronius commented Sep 26, 2020

I am looking at the difference between this repo (thank you for maintaining!) and original:
https://github.com/jjj/chosen/releases/
https://github.com/harvesthq/chosen/releases/

and see that this one contains compiled assets under ./docs. I don't know how to extract only that file or how to move that folder into my preferred destination project libraries folder using composer for the Drupal chosen module, so instead I modified where Drupal looks for its assets (by tacking on docs/).

Ok this works, but it's not ideal, and I wonder if I can try something different or if there is something on your end that could be done differently to alleviate this one little workaround (ie. provide compiled assets as a separate download here in the repo or if there is some composer config to extract just what I need and discard source).

Thanks!
-Bronius

@JJJ
Copy link
Owner

JJJ commented Jan 14, 2021

Hey @bronius! In those situations, I've just been manually including the compiled assets into the project without using Composer. It's obviously a little more work though.

We could include a build directory, which would be kept up-to-date manually by me basically, until something better comes along anyways. What do you think?

@bronius
Copy link
Author

bronius commented Jan 15, 2021

Happy new year! Thanks for your reply :)
Well, don't bend over backwards for me -- but consider why this library exists (I presume as a replacement for harvest), and how I came to it (seeking a drop-in replacement for an outdated harvest version). To serve that need, yes, a build folder would be so fantastic! I have no idea what it requires to maintain such a thing: extra cycles? something built-in to github but costs something? .. no idea :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants