-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versions of Windows set with non-English languages don't handle the system-ui keyword correctly #210
Comments
@philipbordallo why not just move the And from Joan Xie's blog
|
That post, in my eyes, is invalid. I will rephrase his/her arguments and explain why it is invalid. The first argument: Because the system font might lack multiple weights, we should avoid The second argument is that when using classic theme, the old font stack (Tahoma /SimSun) will come back. As a native Chinese, I know aesthetically it is bad. But it is expected because Therefore, the system handles font-family: Segoe UI, system-ui Note that macOS does not have similar issues thanks to font cascading.
In contrast of using fallbacks, we are using |
@JLHwung thanks for taking the time to write a detailed response. The downside to using Looking at popular websites/css frameworks that all use a "system" font-family stack, I was only able to find one that uses the Maybe the reason why so many exclude it is because of the article and they made the assumption to follow it's advice. Or maybe they've done testing on their own and concluded that the keyword caused issues. But it still remains a fact that in 2019 while "system" font stacks are being used more and more, the actual GitHubfont-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-serif,Apple Color Emoji,Segoe UI Emoji,Segoe UI Symbol font-family: -apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,Helvetica,Arial,sans-serif ESPNfont: 16px -apple-system,BlinkMacSystemFont,"Roboto","Arial","Helvetica Neue","Helvetica",sans-serif; font-family: -apple-system,system-ui,BlinkMacSystemFont,"Segoe UI",Roboto,"Helvetica Neue","Fira Sans",Ubuntu,Oxygen,"Oxygen Sans",Cantarell,"Droid Sans","Apple Color Emoji","Segoe UI Emoji","Segoe UI Emoji","Segoe UI Symbol","Lucida Grande",Helvetica,Arial,sans-serif; Wordpress Adminfont-family: -apple-system,BlinkMacSystemFont,Segoe UI,Roboto,Oxygen-Sans,Ubuntu,Cantarell,Helvetica Neue,sans-serif; Notionfont-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Helvetica, "Apple Color Emoji", Arial, sans-serif, "Segoe UI Emoji", "Segoe UI Symbol" Bootstrapfont-family: -apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Helvetica Neue",Arial,"Noto Sans",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; Tachyonsfont-family: -apple-system,BlinkMacSystemFont,avenir next,avenir,helvetica neue,helvetica,ubuntu,roboto,noto,segoe ui,arial,sans-serif; Tailwindfont-family: -apple-system,BlinkMacSystemFont,Segoe UI,Roboto,Helvetica Neue,Arial,Noto Sans,sans-serif,Apple Color Emoji,Segoe UI Emoji,Segoe UI Symbol,Noto Color Emoji |
@philipbordallo Sorry for the late reply. I think that I realize that a Related: w3c/csswg-drafts#3658 |
Not having to remember all the different variations/reasons for those variations of font family per system seems like a decent incentive. Especially if something like Also I forgot to add Twitter to the list as someone using font-family: system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Ubuntu, "Helvetica Neue", sans-serif; Side note: It would be cool to dig through the HTTP Archive's dataset and see who else is using |
|
Looking into the use of the raw
system-ui
keyword, I noticed most websites/css frameworks don't use it and instead just have the compiled list of fallbacks. This post by Joan Xie details that it has something to do with the fact that certain versions of Windows set with non-English languages don't handle thesystem-ui
keyword correctly.Does it make sense to give users the option to not preserve the
system-ui
keyword and instead just use the fallbacks? Similar to how postcss-custom-properties handles preservation of custom properties.This way a user doesn't need to supply their own
family
option to fix this issue and still gets the benefits of postcss-font-family-system-ui constructing the list of fallbacks.The text was updated successfully, but these errors were encountered: