Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to pass our own command line arguments? #290

Closed
AdamMc331 opened this issue Oct 1, 2019 · 3 comments
Closed

Is it possible to pass our own command line arguments? #290

AdamMc331 opened this issue Oct 1, 2019 · 3 comments
Labels

Comments

@AdamMc331
Copy link
Contributor

I am uncertain if this is supported and I couldn't find anything in the README for it. The scenario I'm trying to account for is if ktlint bumps a version with a new command argument but this plugin hasn't updated yet. Thankfully we can specify the ktlint version ourselves, but I'm not sure I would be able to account for a new flag. The one in question, if it matters, is this PR that was just merged: pinterest/ktlint#585 (comment)

I'm happy to contribute to the solution, I'm just not sure if:

  • This is not possible, so I should wait until ktlint is updated (which I have to do regardless) and then submit a PR into the plugin.
  • This is supported, and we should update the README to explain how we can do this.
  • This is not supported, so I should explore ways we can implement such capabilities.

Let me know what I can do to help. Thanks!

@Tapchicoma
Copy link
Collaborator

Regarding additional command line arguments - it is not possible. To add support for --color-name this plugin should be updated, though not a big change and could be done after ktlint will have next release.

If you want to try ktlint snapshot, it is possible after pinterest/ktlint#588 will be merged - just use 5.35.0-SNAPSHOT version in ktlint-gradle configuration.

@AdamMc331
Copy link
Contributor Author

Cool, thanks for the feedback! Should we close this and open a new ticket to support color-name when the time comes? That seems better than editing this so the question doesn't get lost.

@Tapchicoma
Copy link
Collaborator

Should we close this and open a new ticket to support color-name when the time comes?

Yes, would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants