Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is the pre-commit git hook silent? #649

Open
mobilekosmos opened this issue Mar 3, 2023 · 1 comment
Open

Why is the pre-commit git hook silent? #649

mobilekosmos opened this issue Mar 3, 2023 · 1 comment

Comments

@mobilekosmos
Copy link

mobilekosmos commented Mar 3, 2023 •
edited
Loading

The generated pre-commit git hook includes this line:

./gradlew --quiet ktlintCheck -PinternalKtlintGitFilter="$CHANGED_FILES"

Why does this run by default quiet and is it possible to configure this while running gradlew addKtlintCheckGitPreCommitHook?
@JLLeitschuh
Copy link
Owner

🤷 Personally, I never thought that this plugin should have a dedicated pre-commit feature. I figured that should be left to some other plugin to support. For example: https://github.com/DanySK/gradle-pre-commit-git-hooks

I'm not wedded to any of the decisions around the pre-commit hook, and you're welcome to PR a change to make it more configurable for your use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mobilekosmos @JLLeitschuh