Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails Node audit (HIGH vulnerability) #61

Closed
chladnefazole opened this issue Dec 28, 2022 · 2 comments
Closed

Fails Node audit (HIGH vulnerability) #61

chladnefazole opened this issue Dec 28, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@chladnefazole
Copy link

chladnefazole commented Dec 28, 2022

Describe the bug
This package isn't secure, it depends on an old version of mssql which has a bunch of jsonwebtoken issues:

  • jsonwebtoken's insecure implementation of key retrieval function could lead to Forgeable Public/Private Tokens from RSA to HMAC - GHSA-hjrf-2m68-5959
  • jsonwebtoken vulnerable to signature validation bypass due to insecure default algorithm in jwt.verify() - GHSA-qwph-4952-7xr6
  • jsonwebtoken unrestricted key type could lead to legacy keys usage - GHSA-8cf7-32gw-wr33
  • jsonwebtoken has insecure input validation in jwt.verify function - GHSA-27h2-hvpr-p74q

To Reproduce

  • Run npm install connect-mssql-v2
  • Run npm audit
  • Error is there

Expected behavior
Package should be updated to use mssql ^7.2.0

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows
  • Node Version: >=14
  • Package Version: 3.1.4

Additional context
This is the only working session manager package for Microsoft SQL Server/TSQL and Node, and the vulnerabilities are significant. This could cause a lot of sites using MSSQL to become insecure as a result.

@chladnefazole chladnefazole added the bug Something isn't working label Dec 28, 2022
@JLuboff
Copy link
Owner

JLuboff commented Dec 30, 2022

Hi @chladnefazole, thanks for bringing this up. npm audit fix solution would be to downgrade mssql to v7 which, I don't agree with. These vulnerabilities still exist in v9 but as one of the maintainers of mssql states, it is likely not an issue as no authentication takes place in the mssql library (see: tediousjs/node-mssql#1451).

@chladnefazole
Copy link
Author

@JLuboff Ok, understood. It's not a problem for my project but might be in some corporate setup where they don't allow any high-level vulnerabilities. But I understand that this vulnerability is not relevant to mssql.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants