Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin fails to load images #48

Closed
polarbearing opened this issue Apr 16, 2017 · 7 comments
Closed

Plugin fails to load images #48

polarbearing opened this issue Apr 16, 2017 · 7 comments
Labels

Comments

@polarbearing
Copy link

polarbearing commented Apr 16, 2017

Since I recently updated JOSM (and thereby most likely the plugin), the sequences load and show up, but the images do not.

JOSM/1.5 (11926 en) Mac OS X 10.11.6
Memory Usage: 1416 MB / 3641 MB (334 MB allocated, but free)
Java version: 1.8.0_111-b14, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
+ Mapillary (v1.5.1)

Once I mouse-over or click an image node, java throws an event as below. After working while having the mapillary layer on, JOSM freezes and needs to be killed.

java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location
	at java.awt.Component.getLocationOnScreen_NoTreeLock(Component.java:2062)
	at java.awt.Component.getLocationOnScreen(Component.java:2036)
	at javax.swing.JPopupMenu.show(JPopupMenu.java:948)
	at org.openstreetmap.josm.plugins.mapillary.gui.imageinfo.ImageInfoHelpPopup.showPopup(ImageInfoHelpPopup.java:77)
	at org.openstreetmap.josm.plugins.mapillary.gui.MapillaryMainDialog.updateImage(MapillaryMainDialog.java:209)
	at org.openstreetmap.josm.plugins.mapillary.gui.MapillaryMainDialog.updateImage(MapillaryMainDialog.java:185)
	at org.openstreetmap.josm.plugins.mapillary.mode.SelectMode.mouseMoved(SelectMode.java:181)
	at java.awt.AWTEventMulticaster.mouseMoved(AWTEventMulticaster.java:330)

etc.

Tracing versions, the problem started when I upgraded to JOSM 11879 on Apr 10, before that I was running 11604 with mapillary working fine.

@polarbearing
Copy link
Author

Dup of JOSM ticket

@floscher
Copy link
Member

0e141af fixes this problem.
The latest release v1.5.2 contains the fix, so it should now work again.

@floscher floscher added the bug label Apr 17, 2017
@ghost
Copy link

ghost commented Apr 17, 2017

Not fixed.

Running v1.5.2:

notfixed

@floscher floscher reopened this Apr 17, 2017
@floscher
Copy link
Member

I'm sorry, this was introduced by me in 8961dd0.
I changed how the download URLs are generated and unintentionally changed the .jpg file extension to .png. Because of that, no new images are downloaded, only cached images are shown.

I'm currently preparing a hotfix release, which will fix this issue.

The issue previously reported here is technically unrelated and should really already be fixed.

@floscher
Copy link
Member

@M1dgard Ok, version 1.5.3 is now released as a hotfix release and will shortly be available to all JOSM users. It contains the fix for this problem.

@polarbearing
Copy link
Author

1.5.2:
Yes, while I don't get java.awt.IllegalComponentStateException anymore, I get error 403 from the cloud server:
INFO: GET https://d1cuyjsrcm0gby.cloudfront.net/.../thumb-320.png -> 403
1.5.3
works:
INFO: GET https://....cloudfront.net/.../thumb-2048.jpg -> 200 (632 kB)

@floscher
Copy link
Member

floscher commented Apr 17, 2017

@polarbearing Exactly, sorry for the inconvenience. That's what happens, when I release software without adding accompanying unit tests 😉 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants