Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indoorhelper freezes JOSM #7

Closed
GerdP opened this issue Sep 25, 2020 · 4 comments
Closed

indoorhelper freezes JOSM #7

GerdP opened this issue Sep 25, 2020 · 4 comments

Comments

@GerdP
Copy link

GerdP commented Sep 25, 2020

See https://josm.openstreetmap.de/ticket/19618
I wonder if the code to handle tag repeat_on did ever work? I tried with older versions downto r14153 of JOSM and they all freeze.

@rebeccasc
Copy link
Member

Fixed in e3ea14b. Will be part of the next release.

@GerdP
Copy link
Author

GerdP commented Oct 1, 2020

Thanks for looking into this.
I wonder why you use this iteration
for (Map.Entry<String, String> entry : primitive.getInterestingTags().entrySet()) {
if (entry.getKey().equals(key)) {
foo();
}
}
..
you can use
primitive.get(key)
to retrive the value of a tag.

I also wonder why the loop calls
primitive.setDisabledType(true);
for a primitive that already is disabled.

@rebeccasc
Copy link
Member

I removed the unnecessary code lines and refactored a little in cbdbae9. Thanks for the review!

@rebeccasc
Copy link
Member

See Release v.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants