Skip to content

Commit 0244905

Browse files
Fix: mysql comment with = (#1936)
* Fix: mysql comment with `=` * Fix: mysql comment with `=`
1 parent 256a1ef commit 0244905

File tree

4 files changed

+13
-3
lines changed

4 files changed

+13
-3
lines changed

src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -442,8 +442,11 @@ public String toString() {
442442
// Oracle Multi Column Drop
443443
b.append("DROP (").append(PlainSelect.getStringList(pkColumns)).append(')');
444444
} else {
445-
b.append(operation).append(" ");
446-
445+
if (operation == AlterOperation.COMMENT_WITH_EQUAL_SIGN) {
446+
b.append("COMMENT =").append(" ");
447+
} else {
448+
b.append(operation).append(" ");
449+
}
447450
if (commentText != null) {
448451
if (columnName != null) {
449452
b.append(columnName).append(" COMMENT ");

src/main/java/net/sf/jsqlparser/statement/alter/AlterOperation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
package net.sf.jsqlparser.statement.alter;
1111

1212
public enum AlterOperation {
13-
ADD, ALTER, DROP, DROP_PRIMARY_KEY, DROP_UNIQUE, DROP_FOREIGN_KEY, MODIFY, CHANGE, ALGORITHM, RENAME, RENAME_TABLE, RENAME_INDEX, RENAME_KEY, RENAME_CONSTRAINT, COMMENT, UNSPECIFIC;
13+
ADD, ALTER, DROP, DROP_PRIMARY_KEY, DROP_UNIQUE, DROP_FOREIGN_KEY, MODIFY, CHANGE, ALGORITHM, RENAME, RENAME_TABLE, RENAME_INDEX, RENAME_KEY, RENAME_CONSTRAINT, COMMENT, COMMENT_WITH_EQUAL_SIGN, UNSPECIFIC;
1414

1515
public static AlterOperation from(String operation) {
1616
return Enum.valueOf(AlterOperation.class, operation.toUpperCase());

src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6500,6 +6500,7 @@ AlterExpression AlterExpression():
65006500
)
65016501
|
65026502
(<K_COMMENT> {alterExp.setOperation(AlterOperation.COMMENT);}
6503+
["=" {alterExp.setOperation(AlterOperation.COMMENT_WITH_EQUAL_SIGN);} ]
65036504
tk=<S_CHAR_LITERAL> { alterExp.setCommentText(tk.image); }
65046505
)
65056506
|

src/test/java/net/sf/jsqlparser/statement/alter/AlterTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -896,6 +896,12 @@ public void testAlterTableDropColumnIfExists() throws JSQLParserException {
896896
assertSqlCanBeParsedAndDeparsed("ALTER TABLE test DROP COLUMN IF EXISTS name");
897897
}
898898

899+
@Test
900+
public void testAlterTableCommentIssue1935() throws JSQLParserException {
901+
assertSqlCanBeParsedAndDeparsed("ALTER TABLE table_name COMMENT = 'New table comment'");
902+
assertSqlCanBeParsedAndDeparsed("ALTER TABLE table_name COMMENT 'New table comment'");
903+
}
904+
899905
@Test
900906
public void testAlterTableDropMultipleColumnsIfExists() throws JSQLParserException {
901907
assertSqlCanBeParsedAndDeparsed(

0 commit comments

Comments
 (0)