Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code complexity in ghosttree.scaffold #33

Open
JTFouquier opened this issue May 6, 2015 · 1 comment
Open

Improve code complexity in ghosttree.scaffold #33

JTFouquier opened this issue May 6, 2015 · 1 comment

Comments

@JTFouquier
Copy link
Owner

Suggestion from D.M.:
line 102, which determines which sequences to write out, is performing a list look up. This can be reduced to O(1). It is also not using the skbio fasta formatter.

@JTFouquier
Copy link
Owner Author

JTFouquier commented Oct 13, 2016

I'm re-labeling this issue because IMO it needs to be this way because of having to traverse through the genera and then find the corresponding accession number that matches the current genus. I thought about it a while, but I do think it's necessary to keep it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant