Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle 304 responses #5

Open
JWCook opened this issue Sep 5, 2021 · 1 comment
Open

Handle 304 responses #5

JWCook opened this issue Sep 5, 2021 · 1 comment

Comments

@JWCook
Copy link
Owner

JWCook commented Sep 5, 2021 •
edited
Loading

Some APIs that support conditional requests, like the GitHub API, do not count it against your rate limit if you make a conditional request and get a 304 Not Modified response. It might be convenient to add an option to not apply client-side rate-limiting for 304s.
@JWCook JWCook changed the title Optionally handle 304 responses? Handle 304 responses? Sep 5, 2021
@JWCook
Copy link
Owner Author

JWCook commented Apr 6, 2022

Similar to handling 429 responses (#4) and the limit_statuses option (#34), it also might be useful to provide a no_limit_statuses option to specify additional status codes that don't count against the rate limit.

I'll wait until there's an actual use case for that before implementing, though.

@JWCook JWCook changed the title Handle 304 responses? Handle 304 responses Jan 10, 2023
@JWCook JWCook mentioned this issue Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JWCook