You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'll view this as a bit of a mid-length project. Preliminarily I am looking at
BibtexStringComparator
EntryComparator (break ties with Id)
FieldComparator
FieldComparatorStack (doesn't break ties with Id) -> replace with Comparator.andThen or .reduce(Comparator::thenComparing) -> removed
CrossRefEntryComparator
NumericFieldComparator -> might make a change to its logic, will add test cases if I do
IdComparator
RankingFieldComparator
SpecialFieldComparator
StringLengthComparator -> two uses with Comparator.comparingInt(String::length).reversed()) -> removed
and it seems that EntryComparator and FieldComparatorStack serve the same purpose.
Most of them are essentially unchanged in the last 8 years (i.e., they are pre-GitHub) so I'll take a look at modernizing the ones I believe need it. The changes should lead to a lot less code that is more readable (❤️ Java 8+) so I'd guess it is a one PR change.
Therefore I woud open the PR against JabRef/jabref. Here, we collect PRs, which are suspended or take a veeeeeery long time to finish. This issue here is more a short-term one.
The
EntryComparator
does not call theFieldComparator
.Why?
Should be fixed. - At least JavaDoc should added referencing each other and explaining the differences.
Refs JabRef#7708
The text was updated successfully, but these errors were encountered: