Skip to content

Commit 601a226

Browse files
committed
Store column widths as integer
Fixes #4579
1 parent eab20bf commit 601a226

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

src/main/java/org/jabref/gui/maintable/PersistenceVisualStateTable.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@ private void updateColumnPreferences() {
6161
NormalTableColumn normalColumn = (NormalTableColumn) column;
6262

6363
columnNames.add(normalColumn.getColumnName());
64-
columnsWidths.add(String.valueOf(normalColumn.getWidth()));
64+
columnsWidths.add(String.valueOf(Double.valueOf(normalColumn.getWidth()).intValue()));
6565
}
6666
}
6767

68-
if (columnNames.size() == columnsWidths.size() &&
69-
columnNames.size() == preferences.getStringList(JabRefPreferences.COLUMN_NAMES).size()) {
68+
if ((columnNames.size() == columnsWidths.size()) &&
69+
(columnNames.size() == preferences.getStringList(JabRefPreferences.COLUMN_NAMES).size())) {
7070
preferences.putStringList(JabRefPreferences.COLUMN_NAMES, columnNames);
7171
preferences.putStringList(JabRefPreferences.COLUMN_WIDTHS, columnsWidths);
7272
}

src/main/java/org/jabref/gui/preferences/TableColumnsTab.java

+8-8
Original file line numberDiff line numberDiff line change
@@ -502,7 +502,7 @@ public void storeSettings() {
502502

503503
for (TableRow tr : data) {
504504
names.add(tr.getName().toLowerCase(Locale.ROOT));
505-
widths.add(String.valueOf(tr.getLength()));
505+
widths.add(String.valueOf(Double.valueOf(tr.getLength()).intValue()));
506506
}
507507

508508
// Finally, we store the new preferences.
@@ -522,14 +522,14 @@ private void updateOrderAction() {
522522
final HashMap<String, Integer> map = new HashMap<>();
523523

524524
// first element (#) not inside data
525-
/*
526-
for (TableColumn<BibEntry, ?> column : panel.getMainTable().getColumns()) {
527-
String name = column.getText();
528-
if ((name != null) && !name.isEmpty()) {
529-
map.put(name.toLowerCase(Locale.ROOT), i);
530-
}
525+
/*
526+
for (TableColumn<BibEntry, ?> column : panel.getMainTable().getColumns()) {
527+
String name = column.getText();
528+
if ((name != null) && !name.isEmpty()) {
529+
map.put(name.toLowerCase(Locale.ROOT), i);
531530
}
532-
*/
531+
}
532+
*/
533533
data.sort((o1, o2) -> {
534534
Integer n1 = map.get(o1.getName());
535535
Integer n2 = map.get(o2.getName());

0 commit comments

Comments
 (0)