Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from bibtex on clipboard to a custom group #11085

Closed
jiewangjs opened this issue Mar 24, 2024 · 10 comments · Fixed by #11271
Closed

Import from bibtex on clipboard to a custom group #11085

jiewangjs opened this issue Mar 24, 2024 · 10 comments · Fixed by #11271
Labels
component: groups FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs

Comments

@jiewangjs
Copy link

Hi, all. In scenarios decribed in the title, I expect the imported entried to appear under the custom group rather than the default "all entries" group.
But what I found is when there is only one entry on clipboard, it works well. When the number of entries on the clipboard are two or more, only the last one will appear under custom group, the others will appear under "all entries" group.
Please fix or make improvements. When I import multiple entries from zotero using bibtex, I want paste them under custom group. If they get scattered into "all entries" group, it is very time-consuming to find them one-by-one and recollect them to custom group.
Thanks!

@Siedlerchr Siedlerchr added component: groups good first issue An issue intended for project-newcomers. Varies in difficulty. [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs labels Mar 24, 2024
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Mar 24, 2024
@github-project-automation github-project-automation bot moved this to Normal priority in Prioritization Mar 24, 2024
@CongLuanTran
Copy link

I wonder if this has been fixed, because I can't reproduce it. All paste to a custom group got placed into that group.

@koppor
Copy link
Member

koppor commented Mar 31, 2024

I wonder if this has been fixed, because I can't reproduce it. All paste to a custom group got placed into that group.

Did you try multiple entries? Both the bug report and your reproducing report miss concrete steps. Think of a "Use Case description" (https://en.m.wikipedia.org/wiki/Use_case; especially read the Example!)

@CongLuanTran
Copy link

Did you try multiple entries? Both the bug report and your reproducing report miss concrete steps. Think of a "Use Case description" (https://en.m.wikipedia.org/wiki/Use_case; especially read the Example!)

Yes, I tried with multiple entries. Recently I tried in both the dev version (from Github) and the msi installer version, and here is where it went weird. Two cases happened:

Case 1: Pasting multiple entries into custom group while using Jabref installed with .msi installer

Version:

  • JabRef 5.12--2023-12-24--4233bad
  • Windows 11 10.0 amd64
  • Java 21.0.1
  • JavaFX 21.0.1+6

Result: It works as expected, all entries from the clip board is placed into the custom group.

Case 2: Pasting multiple entries into custom group while using Jabref from Github fork (as per the instruction from https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/)

Version:

  • JabRef 100.0.0
  • Windows 11 10.0 amd64
  • Java 21.0.2
  • JavaFX 22+30

Result: The reported bug happens, only the first entry is placed into the custom group, the rest only go to "All Entries" group

I hope this help clarify the issue a bit.

@ADm1n766
Copy link

ADm1n766 commented Apr 5, 2024

I would work on this issue, specifically on this task:

Case 2: Pasting multiple entries into custom group while using Jabref from Github fork (as per the instruction from https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/)
Version:
JabRef 100.0.0
Windows 11 10.0 amd64
Java 21.0.2
JavaFX 22+30
Result: The reported bug happens, only the first entry is placed into the custom group, the rest only go to "All Entries" group
I hope this help clarify the issue a bit.

@ThiloteE ThiloteE moved this from Free to take to Reserved in Good First Issues Apr 5, 2024
@ThiloteE ThiloteE added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Apr 5, 2024
Copy link
Contributor

github-actions bot commented Apr 5, 2024

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@ThiloteE
Copy link
Member

ThiloteE commented Apr 5, 2024

@CongLuanTran Please provide some entries you try to copy, so that we can reproduce.

@ThiloteE
Copy link
Member

ThiloteE commented Apr 5, 2024

I am not completely sure, but your issue sounds like a symptom caused by #8836. Fixing this is not trivial, not a good first issue and requires lots of thought and a well crafted design for our groups feature. (Btw. JabRef's groups feature is currently actually a "tags" feature. We just call it groups).

@CongLuanTran
Copy link

@CongLuanTran Please provide some entries you try to copy, so that we can reproduce.

So this is a small set that I tried to paste, larger set shows no difference though.

@book{wals,
  address   = {Leipzig},
  editor    = {Matthew S. Dryer and Martin Haspelmath},
  publisher = {Max Planck Institute for Evolutionary Anthropology},
  title     = {WALS Online},
  url       = {https://wals.info/},
  year      = {2013}
}

@incollection{wals-9,
  address   = {Leipzig},
  author    = {Gregory D.S. Anderson},
  booktitle = {The World Atlas of Language Structures Online},
  editor    = {Matthew S. Dryer and Martin Haspelmath},
  publisher = {Max Planck Institute for Evolutionary Anthropology},
  title     = {The Velar Nasal},
  url       = {https://wals.info/chapter/9},
  year      = {2013}
}

@article{labrune2021word,
  title={Word-initial rhotic avoidance: a typological survey},
  author={Labrune, Laurence},
  journal={Glossa: a journal of general linguistics},
  volume={6},
  number={1},
  year={2021},
  publisher={Open Library of Humanities}
}

@ThiloteE
Copy link
Member

ThiloteE commented Apr 7, 2024

Thank you. Those entries do not seem out of the ordinary.

@Siedlerchr
Copy link
Member

I can reproduce the issue now

@github-project-automation github-project-automation bot moved this from Normal priority to Done in Prioritization May 2, 2024
@github-project-automation github-project-automation bot moved this from Reserved to Done in Good First Issues May 2, 2024
@ADm1n766 ADm1n766 removed their assignment Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: groups FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants