Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcuts for "Get bibliographic data from DOI" and "Look up DOI" #11802

Open
Siedlerchr opened this issue Sep 20, 2024 · 6 comments · May be fixed by #11842
Open

Add keyboard shortcuts for "Get bibliographic data from DOI" and "Look up DOI" #11802

Siedlerchr opened this issue Sep 20, 2024 · 6 comments · May be fixed by #11842
Assignees
Labels
entry-editor FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. keybinding type: enhancement

Comments

@Siedlerchr
Copy link
Member

Is your suggestion for improvement related to a problem? Please describe.
Many users wish for this, see discussion in the forum: https://discourse.jabref.org/t/shortcuts-for-get-bibliographic-data-from-doi-and-look-up-doi/4468/

Describe the solution you'd like
I want to trigger the action from the keyboard

Additional context
The feature is located in the entry editor:

grafik
@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Sep 20, 2024
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Sep 20, 2024
@HeroxHeruxum
Copy link

HeroxHeruxum commented Sep 24, 2024

@Siedlerchr Hey, I am looking at this issue for some hours now, but i still cant figure out, where to best put the KeyBindingListeners.
Currently i am messing around in java/org/jabref/gui/frame/JabRefFrame.java.

Also is there any documentation of the Editor-Structure? I know that the functions are within DoiIdentifierEditorViewModel, but im not quite sure, how to best access them.

Any help is much appreciated!

@Siedlerchr
Copy link
Member Author

Siedlerchr commented Sep 25, 2024

@HeroxHeruxum Actually it would be IdentiferViewEditor, the same UI is reused for all kind of identifiers. There the buttons are added.
To add a keybinding to a button you can take a look at the Standard Actions and the configureIconButton methods from ActionFactory

@HeroxHeruxum
Copy link

@Siedlerchr Thanks alot, I think that should set me up for success. Soo I'd like to do this issue ;)
Is it okay if I use Java Docs. or should i just add stuff to the md files?

@Siedlerchr
Copy link
Member Author

@HeroxHeruxum Just start with the PR and follow the checklist (e.g, changelog entry)

@Siedlerchr Siedlerchr added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Sep 26, 2024
Copy link
Contributor

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

@HeroxHeruxum
Copy link

Heres the Draft PR #11842

@ThiloteE ThiloteE linked a pull request Sep 27, 2024 that will close this issue
6 tasks
@ThiloteE ThiloteE moved this from Free to take to Assigned in Good First Issues Oct 5, 2024
@ThiloteE ThiloteE moved this from Assigned to In Progress in Good First Issues Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
entry-editor FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. keybinding type: enhancement
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants