Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo and undo buttons are active without open library #11837

Closed
Siedlerchr opened this issue Sep 26, 2024 · 12 comments · Fixed by #11839
Closed

redo and undo buttons are active without open library #11837

Siedlerchr opened this issue Sep 26, 2024 · 12 comments · Fixed by #11839
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Milestone

Comments

@Siedlerchr
Copy link
Member

          Hello @koppor , I noticed an error yesterday. Maybe, You want to examine. the error is like this:

redo and undo buttons become active when the project is up and running:
redo undo

When you click on these buttons, an error message appears like this:
image

Originally posted by @melisolmez in #463 (comment)

@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label Sep 26, 2024
@Siedlerchr Siedlerchr added this to the 6.0 milestone Sep 26, 2024
@Siedlerchr Siedlerchr added ui good first issue An issue intended for project-newcomers. Varies in difficulty. labels Sep 26, 2024
@github-project-automation github-project-automation bot moved this to Normal priority in JabRef UI Improvements Sep 26, 2024
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Sep 26, 2024
@HoussemNasri
Copy link
Member

I like it when Java throws an exception at line 53 in a class having 42 lines of code :)

@faresbouzayen
Copy link

Hi @Siedlerchr! I'm interested in fixing the redo and undo buttons being active without an open library.

Plan:
Investigate how the button state is managed.
Implement logic to enable buttons only when a library is open.
Test thoroughly to ensure correct behavior.
Update documentation as needed.
I'll start looking into this and reach out if I have questions. Thanks!

@koppor
Copy link
Member

koppor commented Sep 29, 2024

I think @melisomez is already on it at #11839

@Siedlerchr
Copy link
Member Author

It's related but not the same. we need to integrate an additional check e.g.
this.executable.bind(needsDatabase(stateManager)

@melisolmez
Copy link
Contributor

I think @melisomez is already on it at #11839

Actually I am not. I am working on listener just.

@ThiloteE ThiloteE moved this from Free to take to Assigned in Good First Issues Sep 29, 2024
@ThiloteE ThiloteE added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Sep 29, 2024
Copy link
Contributor

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

@subhramit
Copy link
Collaborator

subhramit commented Oct 3, 2024

Hi @Siedlerchr! I'm interested in fixing the redo and undo buttons being active without an open library.

Plan: Investigate how the button state is managed. Implement logic to enable buttons only when a library is open. Test thoroughly to ensure correct behavior. Update documentation as needed. I'll start looking into this and reach out if I have questions. Thanks!

Hey @faresbouzayen, are you actively working on this? I see that you have not even forked the repository yet. Do you need any help? If busy, you can pass this on to other students.

@faresbouzayen
Copy link

Yes you can assign to someone else

@subhramit
Copy link
Collaborator

@maintainers shift this to free-to-take.

@ThiloteE ThiloteE moved this from Assigned to Free to take in Good First Issues Oct 3, 2024
@Siedlerchr Siedlerchr removed the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Oct 3, 2024
@damgam0288
Copy link
Contributor

damgam0288 commented Oct 3, 2024

Hi @Siedlerchr
I'm part of a group of five students looking to contribute to this project as part of an assignment.

Our plan for this issue:

  • Understand how the Undo/Redo buttons enabled/disabled state is managed, specifically what causes the state to change.
  • Investigate the use of "libraryTab" referring to the posted stacktrace.
  • Implement logic between button state and library's open/closed state.
  • Write tests and documentation.
  • Submit a PR if we appear to have solved the issue.

We plan to focus on this for the next 1-2 weeks if assigned. We will engage through the comments, and state if we cannot solve this issue so that it is available to others promptly. Thanks!

@subhramit
Copy link
Collaborator

subhramit commented Oct 3, 2024

I was going to assign @melisolmez as her comment expressing interest (#11839 (comment)) is older, but final call on you guys as it's a university assignment for @damgam0288.
Alternatively: You guys can also suggest any other good first issue to them, if that works.
@Siedlerchr @koppor @ThiloteE @calixtus

@Siedlerchr
Copy link
Member Author

As this is a oneliner it does not make senes to address it with a lot of people so chose any other issue

@Siedlerchr Siedlerchr moved this from Free to take to Assigned in Good First Issues Oct 3, 2024
@github-project-automation github-project-automation bot moved this from Assigned to Done in Good First Issues Oct 4, 2024
@github-project-automation github-project-automation bot moved this from Normal priority to Closed in JabRef UI Improvements Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants