-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate maintable.css to base css #11881
Conversation
add style class for main table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
You can check review dog's comments at the tab "Files changed" of your pull request.
Did you remove the old maintable.css? |
Yup, it's deleted now and removed the stylesheet loading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried. Works good.
I needed to fix an indent.
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
This PR destroyed highlighting on mouse over. @koppor Please do more checks when trying out things!!! |
add style class for main table
Make @ryan-carpenter happy :)
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)