Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for (biblatex) langid field in entry editor #10868

Open
jspitz opened this issue Feb 9, 2024 · 14 comments · May be fixed by #12071
Open

Support for (biblatex) langid field in entry editor #10868

jspitz opened this issue Feb 9, 2024 · 14 comments · May be fixed by #12071
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) bib(la)tex FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement

Comments

@jspitz
Copy link

jspitz commented Feb 9, 2024

JabRef 5.12

I might have overlooked it, but I do not find the rather central langid field in the entry editor. This field defines the principal language of the entry, which is important for hyphenation and whether (sentence) casing is applied. There is also langidopts for fine-tuning (with polyglossia)

The field is described in http://mirrors.ctan.org/macros/latex/contrib/biblatex/doc/biblatex.pdf at section 2.2.3

In my opinion, this should go to the "Optional" tab.

@Siedlerchr
Copy link
Member

Siedlerchr commented Feb 9, 2024

Thanks for the suggestion. In the meantime you can configure the field under Custome entry types.
JabRef's Standard fiels are listed here https://github.com/JabRef/jabref/blob/13870d831e5d98d27127c4f8d9ec67f199d298be/src/main/java/org/jabref/model/entry/field/StandardField.java
We only have "language" as standard field atm

@jspitz
Copy link
Author

jspitz commented Feb 9, 2024

Thanks for the suggestion. In the meantime you can configure the field under Custome entry types.

Thanks, that's what I've done.

@Siedlerchr Siedlerchr added bib(la)tex type: enhancement good first issue An issue intended for project-newcomers. Varies in difficulty. labels Feb 15, 2024
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Feb 15, 2024
@github-project-automation github-project-automation bot moved this to Normal priority in Features & Enhancements Feb 15, 2024
@Skydrite
Copy link
Contributor

Hello. Can I work on this issue? Thank you!

@Siedlerchr Siedlerchr added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Feb 24, 2024
@Siedlerchr Siedlerchr moved this from Free to take to Reserved in Good First Issues Feb 24, 2024
@Skydrite
Copy link
Contributor

Hey, seeing this issue in more detail, it looks to me that the only thing needed to add the 'langid' field is to add it on the StandardFields. Next, I think I will have to work on the exporter so that it exports this info. However, I'm not sure whether I need to work on the importers as well (or which of them). Is there any maintainer who would be able to discuss this with me a bit?

@koppor
Copy link
Member

koppor commented Mar 14, 2024

@Skydrite Just start with the StandardField. No worries about importers. They will emerge gradually. -- Also depends on #11013.

github-merge-queue bot pushed a commit that referenced this issue Mar 19, 2024
* Added langid field in StandardFields

* Fixed placement of addition in CHANGELOG.md

* Update the xml file used in unit test to include table-cell for standard field "langid". Also change enum constant to match other constants in StandardField.java.

---------

Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Enes <E.B.Koca@student.tudelft.nl>
@koppor
Copy link
Member

koppor commented Apr 8, 2024

Closed by #11049

@koppor koppor closed this as completed Apr 8, 2024
@github-project-automation github-project-automation bot moved this from Normal priority to Done in Features & Enhancements Apr 8, 2024
@github-project-automation github-project-automation bot moved this from Reserved to Done in Good First Issues Apr 8, 2024
@jspitz
Copy link
Author

jspitz commented Apr 26, 2024

If I am not missing something, the langid field still is not among the optional fields of any biblatex entry type in JabRef 5.13. #11049 just added it to the fields known by JabRef.

So this request is actually not fully addressed.

@koppor koppor reopened this Apr 26, 2024
@github-project-automation github-project-automation bot moved this from Done to Normal priority in Features & Enhancements Apr 26, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Good First Issues Apr 26, 2024
@koppor koppor removed the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Apr 26, 2024
@koppor
Copy link
Member

koppor commented Apr 26, 2024

@jspitz Sorry that we did not review thoroughly at #11049

Seems, the requirements were not clear.

The field needs to be added as optional field to all biblatex entry types

@Siedlerchr Siedlerchr moved this from In Progress to Free to take in Good First Issues Sep 8, 2024
@mag-sun
Copy link

mag-sun commented Oct 10, 2024

Hi, I am a student at the Australian National University. For one of our assignments, we are tasked with working in a group to contribute to an open-source project - and I would like to be assigned to this issue. While working, our group will cross-review our code and help each other out to have the most efficient progress. Thanks so much!

@ThiloteE ThiloteE moved this from Free to take to Assigned in Good First Issues Oct 10, 2024
@ThiloteE ThiloteE added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Oct 10, 2024
Copy link
Contributor

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

@JabRef JabRef deleted a comment from github-actions bot Oct 10, 2024
@koppor koppor added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Oct 16, 2024
@koppor
Copy link
Member

koppor commented Oct 16, 2024

I copy from the PDF

Image

Image

In the entry editor, it should be a dropdown.

@jspitz Meanwhile, you can configure the Field contgent selector with values you need.

@mag-sun
Copy link

mag-sun commented Oct 18, 2024

Hi, I was just wondering if 'langid' should be considered independently from the existing 'language' field or not? Any guidance around how to approach this issue would be greatly appreciated!

@jspitz
Copy link
Author

jspitz commented Oct 18, 2024

Yes, the two fields are independent. In biblatex, language means "The language(s) of the work. Languages may be specified literally or as localisation keys" (from the manual), while langid is the language used for typesetting the entry.

@mag-sun
Copy link

mag-sun commented Oct 24, 2024

Hello, I have successfully integrated 'langid' as an optional field with a dropdown menu in biblatex entry types. I have drafted a PR, but am unsure if I have completely solved this issue. The selected langid shows up correctly in the BibTex source tab, but I am uncertain as to if it actually changes the formatting of the entry/if that is something covered by importers/exporters. Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) bib(la)tex FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement
Projects
Status: In Progress
Status: Normal priority
Development

Successfully merging a pull request may close this issue.

6 participants