Sanitize URLs in file fields to handle invalid pipe characters ('|') #12156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loses JabRef#11876. - Introduced URLUtil.createUri() and URLUtil.create() to handle URL sanitization. - Replaced direct calls to URI.create() and URI.create().toURL() with the new utility methods. - URLs containing the pipe character ('|') are now properly encoded as '%7C' to prevent parsing errors. - Added test cases to URLUtilTest to verify correct sanitization and URL creation.
|
Am I on the right track to resolve this Issue? |
HoussemNasri
reviewed
Nov 5, 2024
|
|
||
| public static URI createUri(String url) { | ||
| try { | ||
| String urlFormat = url.replace("|", "%7C"); |
There was a problem hiding this comment.
Please add a comment explaining why we are doing this and the relevant references.
koppor
reviewed
Nov 5, 2024
| try { | ||
| String urlFormat = url.replace("|", "%7C"); | ||
| return new URI(urlFormat); | ||
| } catch (URISyntaxException e) { |
|
@hitalo-siriano Are you still on it? The steps to finish it seem to be small. |
|
@koppor Yes, I'm still working on the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11876.