Integrity check should report empty BibTexKey as problem, too

[Siedlerchr]

JabRef version 3.6dev
Steps to reproduce:

1. Create an entry with no BibTeyKey but otherwise all fields set
2. run Integrity Check
3. Integrity check reports no problem

Warning about empty BibtexKey occurs only at startup. However, the integrity checker should report the empty bibtex key, too.

@Patent{,
  author    = {Abraham Lincoln},
  title     = {The Vampire Hunter},
  number    = {12345677},
  year      = {1978},
}

[grimes2]

Empty required fields are indicated with a red entry number field. So it might be more intuitive, that an empty bibtexkey field is also red.

[Siedlerchr]

Refs: koppor#152

[grimes2]

I try to implement this. This is the result:

I've added AuthorTitleYear, because bibtexkey is missing. This is in agreement with the warning on startup.

[Siedlerchr]

Looks good! That would be enough.
If you create PR, we would be pleased 👍

[simonharrer]

Does the "click on item jumps to entry in main table" still work if there is no citekey?

[grimes2]

Unfortunately no.

[Siedlerchr]

@simonharrer I have not looked into the code, but I think that the key is used as reference to located the entry...Maybe we should switch that to id?

[tobiasdiez]

We should switch it to BibEntry, i.e. just keep a reference to the entry and the use/create a method highlight(BibEntry)

[tobiasdiez]

The checker for empty keys is now in place with #2022. I'll keep this open nonetheless as a reminder that we should fix the highlight functionality at some point.

[stefan-kolb]

Follow up in #2181