Preserve % sign inside BibTeX fields via cleanup #2375
Conversation
stefan-kolb
added
the
status: ready-for-review
|
How about a Changelog entry and we are ready to go :) |
| @@ -25,6 +25,9 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `# | |||
| - Replaces manual thread management with cached thread pool | |||
| - Files can now be moved to subfolders named by a custom format pattern, e.g., based on `entrytype`. | |||
| The pattern can be specified in the settings like the filename pattern. [#1092](https://github.com/JabRef/jabref/issues/1092) | |||
|
|
|||
There was a problem hiding this comment.
Why are there two additional newlines here?
There was a problem hiding this comment.
To avoid merge conflicts with other PRs.
There was a problem hiding this comment.
Ok, fine. I would merge this right now, but maybe we should give @bernhard-kleine at least time until the release tomorrow, before we merge and delete the branch.
We should not forget to merge it before the release, though.
| @@ -25,6 +25,9 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `# | |||
| - Replaces manual thread management with cached thread pool | |||
| - Files can now be moved to subfolders named by a custom format pattern, e.g., based on `entrytype`. | |||
| The pattern can be specified in the settings like the filename pattern. [#1092](https://github.com/JabRef/jabref/issues/1092) | |||
|
|
|||
|
|
|||
| - [#2375](https://github.com/JabRef/jabref/issues/2375) LaTeXCleanup action does now preserve % signs inside BibTeX fields | |||
There was a problem hiding this comment.
I would change "preserve" to "escape", and, moreover, "LaTeXCleanup" is not an English word 😄
tobiasdiez
removed
the
status: ready-for-review
|
Put ruhe Latex cleanup in Single quotes as it is a command in
JabRef
|
|
When importing via the firefox plugin the percent sign are excaped. Importing via the medline websearch they are not. I do not find any mentioning in the cleanup dialogue of percent sign changed to % signs. JabRef 3.8 |
|
@bernhard-kleine The cleanup is not done automatically. |
|
I updated to JabRef 3.8 today, i choose the 64bit version. |
|
I had to add it first and then run the cleanup. Sorry for the noise! |
|
I added LaTeX cleanup for the abstract field. Still, percent sign are saved as they are which leads to errors when running biber. In case the percent sign is escaped, jabref removes the backslash when saving. |
|
@j0hannes This has been fixed with #2521 We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. |
|
@Siedlerchr I tried version 4.0 and it seems to be quite unstable; I had to force quit the application each time as it was hanging. Before crashing it destroyed some of the keys, so I'm going back to 3.8.2 now. Is there any other way to address the percent problem? |
|
@j0hannes Could you please open a new issue for the problems you encounter with the 4.0.0 version in detail? You could manually escape the %-signs by adding a Backslash \ before it. That works. |
|
I have raised issues for the backslash and the % sign before. My
problems are gone with Version 4.0.0 using Quality->cleanup entries->
and adding abstract: Latex cleanup the the Run field formatter: before
clicking OK.
The errors due not excaped % signs turn out to be tiresome, since the
error message for example in texstudio plus latexmk are not direct, only
by checking the log you know that a % sign was not escaped.
Am 20.03.2017 um 13:34 schrieb Christoph:
…
@j0hannes <https://github.com/j0hannes> Could you please open a new
issue for the problems you encounter with the 4.0.0 version in detail?
E.g. Operation system, any errors in/from the log?
You could manually escape the %-signs by adding a Backslash \ before
it. That works.
You could simply search for the %-sign to see all problematic entries
and then escape them manually
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2375 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIyh51Vqm2pRk83pefo3h891xvpSBSOCks5rnnJIgaJpZM4LLtFh>.
--
spitzhalde9
D-79853 lenzkirch
bernhard.kleine@gmx.net
www.b-kleine.com, www.urseetal.net
-
thunderbird mit enigmail
GPG schlüssel: D5257409
fingerprint:
08 B7 F8 70 22 7A FC C1 15 49 CA A6 C7 6F A0 2E D5 25 74 09
|
|
After changing my bib file manually, version 4.0 is not crashing anymore. Still, it modifies all my citation keys and I don't find any way to stop it. |
|
@j0hannes Did you run a cleanup operation or a save action? Did you check the keypattern settings? |
|
@Siedlerchr No, it happens right when typing, loading or after inspecting manual changes to the bib file. When typing keys are changed when the focus moves to a different field. |
|
I can confirm that the problem still persists with "abstract: LaTeX cleanup" enabled in version 4.0.0-dev. Every time I enter %, it is immediately changed to % and % ends up as % in the bib file which causes LaTeX to fail. |
|
I can not reproduce this. % sign is correctly escaped (and only once) to |
|
It certainly was caused by the LaTeX to Unicode filter. |
Resolves #2011
You can now use LateXCleanup inside quality->cleanups to escape
%to\%