Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"\~" Escape Sequence Does Not Display Correctly in Entry Table #2458

Closed
pirlite2 opened this issue Jan 12, 2017 · 12 comments
Closed

"\~" Escape Sequence Does Not Display Correctly in Entry Table #2458

pirlite2 opened this issue Jan 12, 2017 · 12 comments
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs status: waiting-for-feedback The submitter or other users need to provide more information about the issue

Comments

@pirlite2
Copy link

JabRef 3.8.1 on Linux Mint 17.3

The Latex backslash tilde escaped diacritic "\~" does not display correctly in the entry table. So, for example, the bibtex entry of "Monta\~{n}a" displays as "Monta na". Note the space in the middle of the word. The "\" escape character seems to be ignored and the "~" character treated as a non-breaking space.

Peter

@lenhard lenhard added the bug Confirmed bugs or reports that are very likely to be bugs label Jan 12, 2017
@lenhard
Copy link
Member

lenhard commented Jan 12, 2017

Hi Peter,

thanks for reporting. I can confirm this, it is a bug in our LaTeX to Unicode converter.

For the record:

  • input: Monta\~{n}a
  • desired output: Montaña

@lenhard lenhard mentioned this issue Jan 12, 2017
3 tasks
@lenhard
Copy link
Member

lenhard commented Jan 12, 2017

Turns out it was not a problem in the converter. We simply forgot to apply the converter for the author column.

@pirlite2 In a few minutes a new version of JabRef that fixes this issue will be available at http://builds.jabref.org/fix-conversion-of-tilde-n/ Could you please install this and verify that it solves your problem?

@lenhard lenhard added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Jan 12, 2017
@pirlite2
Copy link
Author

Yep! That fixes "Monta~{n}a". Thanks.

Curious fix though as many characters with diacritics displayed fine before!

I have, however, found another problem. "Mali'{n}ski" does not display correctly - it displays as "Mali'nski". Note the acute accent does not appear over the 'n' but before it, implying that the "\" is ignored and the single quote is interpreted literally.

Peter

@pirlite2
Copy link
Author

Sorry. Damn Markdown! I should have checked the preview before posting.

I meant "Mali\'{n}ski"

Peter

@Siedlerchr
Copy link
Member

@pirlite2 Does this happen with the fixed version?
Regarding the Markdown here, best way is to put such encoded things into code tags

@Siedlerchr Siedlerchr reopened this Jan 12, 2017
@pirlite2
Copy link
Author

I'm afraid so. It happens with both versions - the 3.8.1 release and the fixed version.

@lenhard
Copy link
Member

lenhard commented Jan 13, 2017

Curious fix though as many characters with diacritics displayed fine before!

For most fields they should work fine. The author field is just very special. In contrast to other fields it has an internal structure (different items separated by and, ,, etc.), which is why we have a separate and complex parsing for it. And there, we forgot to perform the Unicode conversion.

Anyway, I can confirm that "Mali\'{n}ski" does not render as it should. Hopefully, this is just a problem in the Unicode conversion this time. I will look into this and follow up with a separate PR, probably later today.

@lenhard lenhard removed the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Jan 13, 2017
@lenhard lenhard self-assigned this Jan 13, 2017
@lenhard
Copy link
Member

lenhard commented Jan 13, 2017

@pirlite2: This particular conversion probably never worked before. It should work now, though. Could you be so kind and try it out again? A working JabRef should be available here: http://builds.jabref.org/fix-apostroph-n-formatting/

@lenhard lenhard added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Jan 13, 2017
@pirlite2
Copy link
Author

Yep. That works brilliantly! Thanks.

@AEgit
Copy link

AEgit commented Jan 30, 2017

@lenhard:
I just tried the new version 3.8.2. I can confirm that this works for the author column in the entry table. In the entry preview of the article, however, you still get "Mali'{n}ski".

Might be related to this issue (?):
#2460

@lenhard
Copy link
Member

lenhard commented Jan 30, 2017

@AEgit: Thanks for noticing! I think it would be best if you open a new issue for this. I guess it is a similar problem: We are not applying our LatexToUnicode conversion somewhere in the entry preview.

#2460 is something different. There, we do apply the conversion, but the conversion somehow does not work correctly.

@AEgit
Copy link

AEgit commented Jan 30, 2017

@lenhard : Done, see here:
#2498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs status: waiting-for-feedback The submitter or other users need to provide more information about the issue
Projects
None yet
Development

No branches or pull requests

4 participants