Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic for new Sciencedirect pages #2576

Merged
merged 2 commits into from
Feb 21, 2017
Merged

Add logic for new Sciencedirect pages #2576

merged 2 commits into from
Feb 21, 2017

Conversation

stefan-kolb
Copy link
Member

Fixes #2574

@stefan-kolb stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 20, 2017
@stefan-kolb stefan-kolb added this to the v4.0 milestone Feb 20, 2017
@Siedlerchr
Copy link
Member

Changelog and it's ready for merge!

@lenhard
Copy link
Member

lenhard commented Feb 21, 2017

Same here: Looks good code-wise.

Please add a Changelog entry and merge!

@Siedlerchr
Copy link
Member

And please fix codacy by making the one field final static

@stefan-kolb stefan-kolb merged commit 428ae43 into master Feb 21, 2017
@stefan-kolb stefan-kolb deleted the fix-sciencedirect branch February 21, 2017 17:55
Siedlerchr added a commit that referenced this pull request Feb 23, 2017
* upstream/master:
  Revert "Update gradle from 3.3 to 3.4"
  Localization tests (#2582)
  Update IEEEJournalList (#2579)
  Keyword - Special field synchronization (#2583)
  Update gradle from 3.3 to 3.4
  Check similarity of entry when using DOI retrieval with ArXiV (#2575)
  Add logic for new Sciencedirect pages (#2576)
  [WIP] Refactored around the FileAnnotationCache. (#2557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants