Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompletion in search field #3068

Closed
lc9275 opened this issue Aug 2, 2017 · 12 comments
Closed

Autocompletion in search field #3068

lc9275 opened this issue Aug 2, 2017 · 12 comments

Comments

@lc9275
Copy link

lc9275 commented Aug 2, 2017

JabRef 4.0-dev--snapshot--2017-08-02--master--63414b030
Windows 10 10.0 amd64
Java 1.8.0_66

Steps to reproduce:

  1. Type last name of the author say "Lastname"
  2. A suggestion pops up "Lastname, F." and you can already see the item you want in the list
  3. You hit enter, no item is found

This happens in particular if the author field is encoded as e.g. "F. Lastname and G. Rdsfdsf and Z. Ddslkfjddf" instead of "Lastname, F. and Rdsfdsf, G. and Ddslkfjddf, Z."

@lc9275
Copy link
Author

lc9275 commented Aug 2, 2017

As a side note, is there a way to turn auto-completion of? It is very slow and instead of being helpful it just slows me down.

@lenhard lenhard changed the title Issue with searching for author in search box Autocompletion in search field Aug 3, 2017
@lenhard
Copy link
Member

lenhard commented Aug 3, 2017

I can confirm this, author autocompletion has a chance of breaking main table selection. However, let me point out that if you don't hit enter, table sorting works as expected and the correct entries are displayed. So as a quick fix for your problem: don't hit enter.

You can turn of the autocompletion for the entry editor under preferences -> Entry editor -> Enable word/name completion. However, that disables the autocompletion only for the entry editor. We should extend it so that it covers the search box as well.

@Doc73
Copy link
Contributor

Doc73 commented Aug 4, 2017

Similar issue:

  1. I want to add author in the form "surname, name"
  2. I write "surname" --> autocompletion suggests "surname, n."
  3. I continue typing "name" and... then? If I press the Enter key, editor prints "surname, n." and the only way to write "surname, name" appears to be to go with the mouse on another field, because other keys (ex. tab) don't work

It is very annoying!

@lenhard
Copy link
Member

lenhard commented Aug 4, 2017

@Doc73 You might want to have a look at the autocompletion preferences under Options->Preferences->Entry Editor.

There's different ways you can set the autocompletion for names. I have selected "Autocomplete names in Firstname Lastname format only" and "Use full firstname whenever possible". With this setting, I cannot reproduce the problem you describe, I always get the full author name.

Moreover, when you do not like the suggested autocompletion, you can just hit the escape key. Then the autocompletion suggestion disappears and there's no need to select a different field.

@Doc73
Copy link
Contributor

Doc73 commented Aug 4, 2017

@lenhard
Many thanks! I could not find this section in preferences, maybe due to italian translation: "Entry editor" becomes "Modifica voci". I can not imagine a better translation: in this case, English is clearer to me.

I would suggest: "Editor delle voci"

@lenhard
Copy link
Member

lenhard commented Aug 4, 2017

I am glad to hear it helped :)

Regarding the translation: We are always looking for people who help us translate the interface into their native language. It's actually quite easy, requires no programming knowledge, and can be done in your browser. It would be really cool if you help :) Have a look at the contribution guide, the example there is even for the italian menu translation: https://help.jabref.org/en/TranslatingGUI

@Siedlerchr
Copy link
Member

@Doc73 If you find some other inconsistencies in the Italian translation which could be improved, either do it as @lenhard suggests - or you could also talk to @frithnanth who actually does most of the Italian translation.

@Doc73
Copy link
Contributor

Doc73 commented Aug 5, 2017

@lenhard @Siedlerchr
Yes, I'll take a look at these things!

@lenhard
Copy link
Member

lenhard commented Aug 7, 2017

@tobiasdiez Could we modify the enter key in the search box so that it does not select the top autocompletion suggestion? Maybe it would be better to only auto complete in the search box if a user actively selects a suggestion. The current behavior seems to confuse some users.

@stefan-kolb
Copy link
Member

#3522

@github-actions
Copy link
Contributor

This issue has been inactive for half a year. Since JabRef is constantly evolving this issue may not be relevant any longer and it will be closed in two weeks if no further activity occurs.

As part of an effort to ensure that the JabRef team is focusing on important and valid issues, we would like to ask if you could update the issue if it still persists. This could be in the following form:

  • If there has been a longer discussion, add a short summary of the most important points as a new comment (if not yet existing).
  • Provide further steps or information on how to reproduce this issue.
  • Upvote the initial post if you like to see it implemented soon. Votes are not the only metric that we use to determine the requests that are implemented, however, they do factor into our decision-making process.
  • If all information is provided and still up-to-date, then just add a short comment that the issue is still relevant.

Thank you for your contribution!

@lc9275
Copy link
Author

lc9275 commented Jan 6, 2021

I am closing this, as all these issues have been fixed (as far as i can tell). Thanks a lot!

@lc9275 lc9275 closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants