Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to group works like add to group #3101

Closed
dfioravanti opened this issue Aug 14, 2017 · 3 comments
Closed

Move to group works like add to group #3101

dfioravanti opened this issue Aug 14, 2017 · 3 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs groups
Milestone

Comments

@dfioravanti
Copy link

JabRef version 4.0-beta2 on Ubuntu 17.04 with oracle JVM

Steps to reproduce:

  1. Add an entry to a group
  2. Right click and press move to group
  3. The entry is added to the new group but not removed from the old one
@lenhard
Copy link
Member

lenhard commented Aug 14, 2017

I can confirm this.

@tobiasdiez What is the actual desired behavior for "Move to group"? Clear all prior groups and move it to the new one?

@lenhard lenhard added groups status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Aug 14, 2017
@dfioravanti
Copy link
Author

I noticed another thing, dragging and dropping an entry into a group works as add to group too. No idea what is the indented behaviour but as user I would expect it to move the entry not to simply add it.

@tobiasdiez
Copy link
Member

tobiasdiez commented Aug 14, 2017

@lenhard, yes I also would expect "Move to group" to remove the selected entries from their previous groups and then adds them to the new one. It seems that https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/gui/groups/GroupAddRemoveDialog.java#L176 is missing a if(move) { foreach group.removeEntries(...)} statement.

@diravan, I think you can control the drag & drop behavior by using the Ctrl (and/or Shift) modifier. I.e. holding Ctrl/Shift and drop the entries should move them.

@lenhard lenhard added bug Confirmed bugs or reports that are very likely to be bugs and removed status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Aug 15, 2017
@lenhard lenhard added this to the v4.0 milestone Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs groups
Projects
None yet
Development

No branches or pull requests

3 participants