Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu bar at wrong position on Mac OS #3146

Closed
cedmfr opened this issue Aug 22, 2017 · 15 comments
Closed

Menu bar at wrong position on Mac OS #3146

cedmfr opened this issue Aug 22, 2017 · 15 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs os: macOS status: help wanted ui

Comments

@cedmfr
Copy link

cedmfr commented Aug 22, 2017

JabRef version 4.0-beta3
The menu bar is included into the main windows as it should be fixed into the Mac OS menu bar.

@Siedlerchr
Copy link
Member

@chochreiner Do you know if this is possible/was possible with java?

@cedmfr cedmfr changed the title Title bar at wrong position on Mac OS Menu bar at wrong position on Mac OS Aug 24, 2017
@cedmfr
Copy link
Author

cedmfr commented Aug 24, 2017

I don't know. Just the menu bar in macOS is not included in the current window but stack into the upper bar of the screen.

@LinusDietz
Copy link
Member

@cedmfr Can you provide a screenshot to clarify the problem? For me the title bar is quite where I would expect it.

JabRef 4.0-dev
Mac OS X 10.12.6 x86_64
Java 1.8.0_144

@LinusDietz LinusDietz added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Aug 28, 2017
@cedmfr
Copy link
Author

cedmfr commented Aug 28, 2017

Please find attached a screenshot of the trouble. In previous Jabref versions those 2 bars were merged on the top bar of macOS.
capture d ecran 2017-08-28 a 17 31 16

@LinusDietz LinusDietz added ui and removed status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Aug 28, 2017
@LinusDietz LinusDietz self-assigned this Aug 28, 2017
@LinusDietz
Copy link
Member

@cedmfr thanks for the clarification, I'll investigate the issue.

@tobiasdiez
Copy link
Member

This could be a consequence of the transition to JavaFX (as the whole application is now started under the JavaFX umbrella

public class JabRefMain extends Application {
). Maybe a related/helpful discussion: https://stackoverflow.com/questions/22569046/how-to-make-an-os-x-menubar-in-javafx

@chochreiner
Copy link
Collaborator

yes, this is due to the migration to JavaFX.

The current approach in JabRefGUI.java only works with swing.

// This property is set to make the Mac OSX Java VM move the menu bar to the top of the screen if (OS.OS_X) { System.setProperty("apple.laf.useScreenMenuBar", "true"); }

So far I have not found any possibility how to restore this feature for the JMenuBar within a JavFX application.
I fear this can be only fixed as soon as the JMenuBar is also migrated to a JavaFX component.

@jiajunwu
Copy link

jiajunwu commented Oct 4, 2017

Just curious if there happens to be a chance to resolve this? It seems the above stackoverflow link offers several possible solutions. Would any of them work?

@LinusDietz
Copy link
Member

@jiajunwu I have tried this a month ago with some hacks as decribed in the stackoverflow threads, but it seems like we have to go the long way by implementing the whole menubar in javafx to get this working (as @chochreiner suggested).
We are quite happy to have 4.0 released, as we (hopefully) can now focus on such improvements...

@jiajunwu
Copy link

jiajunwu commented Oct 4, 2017

Thank you @lynyus . It'd be great to see this happen; I like 4.0 a lot and to me this is the only part where 3.6 is doing better on..

@tobiasdiez tobiasdiez added the bug Confirmed bugs or reports that are very likely to be bugs label Oct 29, 2017
@LinusDietz
Copy link
Member

This still persists, gave it another try today, but to no avail (;

@LinusDietz LinusDietz removed their assignment Dec 28, 2017
@Siedlerchr
Copy link
Member

Seems like we need to migrate the menubar to javafx first

@Siedlerchr
Copy link
Member

Him could @jiajunwu @LinusDietz could you please check if it works in the javafx-global version?

Could you please check the build from https://builds.jabref.org/javafxGlobalEverything/ ?. Thanks! Note this version is in a very early beta stage and might not work as expected. See #3621 for further details.

@LinusDietz
Copy link
Member

LinusDietz commented Feb 20, 2018

screen shot 2018-02-20 at 13 31 14

not quite. The actual titlebar of the MacOS just says "JabRef".

@tobiasdiez
Copy link
Member

tobiasdiez commented Feb 20, 2018

This should be fixed in the latest development version. Could you please check the build from https://builds.jabref.org/maintable-beta/. Thanks! Note this version is in a very early beta stage and might not work as expected. See #3621 for further details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs os: macOS status: help wanted ui
Projects
None yet
Development

No branches or pull requests

7 participants