-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Untranslated text #3397
Comments
Refs #3184 |
@tobiasdiez I was aware of that and carefully checked that all usages did not use underscores. There was at this time only one instance that needed to be replaced. I'm sorry, I should have pointed this out more clearly back then: To make a fast cache, the un-quoting and translating of the messages is done on the first instantiation. Messages in code |
@halirutan Its perfectly fine! I actually like that the underscore version does no longer work (it was a relic of old times). |
I added a test that will take care of this.
|
In todays master, for example:
Warning: could not get message translation for "Create_blank_entry_linking_the_PDF" for locale en
Warning: could not get message translation for "Create_entry_based_on_XMP-metadata" for locale en
Warning: could not get message translation for "Create_entry_based_on_content" for locale en
Warning: could not get message translation for "Only_attach_PDF" for locale en
The problem is the old format using the underscore. I think the were missed, when @halirutan improved the language handling. Our tests should be adapted to report warnings in this cases (just report them as not found).
The text was updated successfully, but these errors were encountered: