Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bibtex parser - Found unbracketed comment #3956

Closed
Siedlerchr opened this issue Apr 15, 2018 · 2 comments
Closed

Bibtex parser - Found unbracketed comment #3956

Siedlerchr opened this issue Apr 15, 2018 · 2 comments

Comments

@Siedlerchr
Copy link
Member

  1. Create a new db with this entry
  2. Save, bibtex parser complains about ubracketed comment

As far as I remember and according to this information here, it should be valid:
http://maverick.inria.fr/~Xavier.Decoret/resources/xdkbibtex/bibtex_summary.html
@lenhard @koppor As you have some deeper insight into the bibtex "standard", do you know if JabRef behaves here correct?

@COMMENT { BibTex package created by Trove, National Library of Australia https://trove.nla.gov.au }

@Book{Artillery1914a,
  author        = {Australia. Army. Royal Field Artillery},
  title         = {Standing orders of the Royal Australian Field Artillery : 1914},
  year          = {1914},
  language      = {English},
  note          = {State Library of NSW. M 358.21/A},
  publisher     = {Melbourne : Albert J. Mullett, Govt. Printer},
  catalogue-url = { https://trove.nla.gov.au/work/21191657 },
  subjects      = { Australia. Army. Royal Field Artillery; Australia. Army -- Regulations },
  timestamp     = {2018-04-15},
  type          = {Book; Book/Illustrated},
}
@koppor
Copy link
Member

koppor commented Apr 16, 2018

The entry has TWO things inside. This is currently unsupported at JabRef.

JabRef kind of accepts pasting that string as a whole in the entry table, but drops the @COMMENT.

Two options:

A) Accept that this comment is dropped
B) Enhance JabRef to handle @COMMENT properly, too.

We store the comments to an entry at the data structure, but IMHO do not show it.

We renamed the "Review" field to "Comments" (@LinusDietz at #3658), which might get confusing now.

grafik

Not sure whether we should migrate comments above an entry into the entry itself. I don't think so. We should nevertheless offer a field in the entry editor showing "Annotations", which means the comments above the entry.

I think, this refs #391.

@Siedlerchr
Copy link
Member Author

I would vote for option A. When I copy and entry it should be copied complete, event with uncommented stuff. But I personally never used that feature. That entry was from the data in #3946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants