Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't permanently integrate non-default jstyles into Jabref (V 4.3.1) #4308

Closed
PaulD02 opened this issue Aug 31, 2018 · 7 comments
Closed

Can't permanently integrate non-default jstyles into Jabref (V 4.3.1) #4308

PaulD02 opened this issue Aug 31, 2018 · 7 comments
Assignees
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. openoffice/libreoffice

Comments

@PaulD02
Copy link

PaulD02 commented Aug 31, 2018

Can integrate a personal jstyle into Jabref and create the desired reference list in Libreoffice, but can’t get it to integrate permanently in Jabref. Tools -> OpenOffice/LO connection -> Select Style -> + Button -> Add style file works fine but after rebooting Jabref the style isn’t available anymore in Jabref and I have to add the file again.

I have tested the latest master version from http://builds.jabref.org/master/ and the problem persists

JabRef version 4.3.1 on Windows 10 64bit

@tobiasdiez tobiasdiez added openoffice/libreoffice good first issue An issue intended for project-newcomers. Varies in difficulty. labels Aug 31, 2018
@antesaj
Copy link

antesaj commented Sep 17, 2018

Is it necessary for loadExternalFiles() within StyleLoader.java (org.jabref.logic.openoffice) to check for validity? Styles are checked for validity prior to being placed into externalStyles i.e. addStyleIfValid(String filename).

External styles are set after each addition in storeExternalStyles() which sets the external styles list within an instance of OpenOfficePreferences.

Where in the application are current OpenOfficePreferences loaded upon startup? I see a getOpenOfficePreferences() method in JabRefPreferences.java but I'm not seeing that method called anywhere. Perhaps it needs to be called in JabRefPreferences.getInstance() (This is called in JabRefMain.java.

@Siedlerchr
Copy link
Member

@antesaj Thanks for your interest, but this is kind of fixed now as I am reworking the whole dialog to javafx and fixed that issue #4341

@antesaj
Copy link

antesaj commented Sep 17, 2018

Got it, great. Well I had fun looking into it anyway xD.

@Siedlerchr
Copy link
Member

There are a couple of other issues that need investigation. Maybe you could take a look at them?

@antesaj
Copy link

antesaj commented Sep 17, 2018

Yes, of course. I've been looking for a good open source Java project to get involved with. I'll browse through the issues; any in particular you have in mind?

@Siedlerchr Siedlerchr self-assigned this Sep 17, 2018
@Siedlerchr
Copy link
Member

@antesaj Maybe you can take a look at that issue here #4023 which is still a problem in the current master. Thanks for your interest in JabRef!
The detection of multiple instances does not work correctly and the thread does not shutdown correctly.
If you have any problems or questions just ask in our gitter chat. You can take also a look at any other open issue if you want.

@Siedlerchr
Copy link
Member

Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. openoffice/libreoffice
Projects
Archived in project
Development

No branches or pull requests

4 participants