Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jabref Stars #4370

Closed
alfureu opened this issue Oct 14, 2018 · 7 comments
Closed

Jabref Stars #4370

alfureu opened this issue Oct 14, 2018 · 7 comments

Comments

@alfureu
Copy link

alfureu commented Oct 14, 2018

It would be great if the stars would be consistent with the stars in the table headings.

Another issue is with the read status, the colours of which are almost invisible, if the item is selected

jabref_stars

@Siedlerchr Siedlerchr added ui type: enhancement good first issue An issue intended for project-newcomers. Varies in difficulty. labels Oct 14, 2018
@tobiasdiez tobiasdiez removed the good first issue An issue intended for project-newcomers. Varies in difficulty. label Oct 14, 2018
@tobiasdiez
Copy link
Member

That's sadly not possible at the moment, because the library that we use for the stars in the main table does not allow for customization. Depends on https://bitbucket.org/controlsfx/controlsfx/pull-requests/685/make-rating-star-node-accessible-for/diff.

@alfureu
Copy link
Author

alfureu commented Oct 14, 2018

What about changing the library for the needs of JabRef or using some other solution? No other solution possible for fixing this?

@LinusDietz
Copy link
Member

Hey @DOFfactory, sure that would be the way to go. We are working hard to improve the UI of JabRef, however we have limited developer resources and currently focus on the more fundamental issues. If you (or anybody else reading this) has some time and knows some Java, this would be a nice contribution to fix!

@alfureu
Copy link
Author

alfureu commented Oct 17, 2018

Hi @LinusDietz, I greatly appreciate all your efforts. I am afraid I cannot help you out with Java. Unfortunately, I had to revert back to v4.3.1, as this rather crucial feature for literature reviewing works perfectly well in that version. The issue is that sometimes JabRef v4.3.1 every now and then hooks up my CPU, as reported earlier #4171. I think it has something to do with incorrectly closing Java in the background.
jabref_stars

@Ali96kz
Copy link
Contributor

Ali96kz commented Oct 18, 2018

@LinusDietz Can you help me with that issue?
P.S. as I understand there is no way to make stars smaller in controlsfx.

@alfureu
Copy link
Author

alfureu commented Oct 18, 2018

The link from @tobiasdiez refers to some CSS modding ... not sure what the author meant

@Siedlerchr
Copy link
Member

Thanks to @Ali96kz this is now fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants