Issues depending on external libraries

[stefan-kolb]

From #3421

• Reimplement stuff concerning TextAreaSkin and TextFieldSkin
• Fix and reenable CitationStyleTests

Morerover, the following needs to be fixed at some point but we cannot do much at the moment:

• Remove workaround for latex2unicode dependencies as soon scala does support Java modules and they are updated with proper module names: Refs Bump latex2unicode_2.12 from 0.2.6 to 0.3.0 #8639
• Remove openoffice workaround as soon as they provide proper module information:: Requires LibreOffice Version 7 to be avaiable everywhere and beeing declared as stable https://bugs.documentfoundation.org/show_bug.cgi?id=117331
• Update error-prone as soon as UnusedNestedClass leads to NullPointerException (with repro) google/error-prone#1240 is fixed -> waiting for next release; error prone has been removed in 346e105
• Remove access to internal libraries which mostly come from controls-fx: https://github.com/controlsfx/controlsfx/blob/452e23e4d9e6d2e2fcddb1640e4fc5fc258221a1/build.gradle#L12-L41
• Specify add-opens and add-exports using moduleOptions (precondition: new version of gradle-modules-plugin is released (> 1.5.0))
• Simplify configuration of jlink as soon as more packages are modularized
• Use jlink instead of shadowJar
• Use jpackage as soon as java 14 is released
• Reenable WebFetcher tests as soon as Not working with Java 9 ronmamo/reflections#202 is fixed. Replaced with other library.
• Reenable wiremock tests (MimeTypeDetectorTest) as soon as wiremock is modularized Add module description for java 9+ compatibility wiremock/wiremock#1162
• Revert 7932dce (and/or test run on classpath) and so reenable archunit tests, requires ArchUnit > 0.23.1, which includes Add module description for java 9+ compatibility TNG/ArchUnit#206
• Fix log4j appenders: https://issues.apache.org/jira/browse/LOG4J2-2690
• Revert 29cf4f2 as soon as https://issues.apache.org/jira/browse/TIKA-2929 is fixed
• Revert f30c3b9 OpenOffice connection as soon the official bug is fixed or a workaround/ is presented https://bugs.documentfoundation.org/show_bug.cgi?id=127557
• Upgrade to Java 13 (Upgrade to JDK 13 #5427) as soon as Upgrade ASM to 7.2 in order to support Java 13 beryx/badass-jlink-plugin#99 is merged and released
• Upgrade to stable release 4.0 of test-fx once it is released (see e.g [WIP] Use snapshot version of testfx-core 4.0.x #5397)
• Revert Temporary Fix for ColorPicker in Groups #5459 as soon as Incompatibilities between JFoenix 9.0.8 and OpenJFX 12 / OpenJDK 12 (JFXDatePicker, JFXTimePicker) sshahine/JFoenix#966 is fixed. Refs JFXColorPicker not compatible with JDK12 #5458
• Revert Support latest version of Jpackage #5559 as soon as jpackage bug is fixed
• Upgrade java-diff-utils as soon as Problem with using 4.4 in modularized project (cannnot determine module name) java-diff-utils/java-diff-utils#60 is fixed
• Remove hack for WeightedPreReleaseNumber null on tag WeightedPreReleaseNumber null on tag GitTools/GitVersion#1994 as soon as GitVersion > 5.3.2 is released https://github.com/GitTools/GitVersion/releases/
• Remove special handling of new Java 14 switches and checkstyle as soon as the fix for Support for Java 14 switch/yield expression checkstyle/checkstyle#6615 is released
• Revert Try to fix dark theme path #5497 as soon as JavaFX is updated to include 8240969: WebView does not allow to load style sheet in modularized applications openjdk/jfx#22 (which is probably 16 or 17)
• Revert adoptopenjdk/zulu hack as soon as jdk 15 is released
• Revert manual signing Add signing for mac osx.  #6748 as soon as https://bugs.openjdk.java.net/browse/JDK-8251892 is fixed --> Provide MWE to JDK-8251892 koppor/jabref#480
• Switch to JDK 16 on Windows as soon as it is released. Cause: Windows DEP bug is fixed. Marked as duplicate of https://bugs.openjdk.java.net/browse/JDK-8254920. Should be fixed with JDK16.
• Update javax.xml.bind to jakarta.xml.bind (see [WIP] Try with jaxb 3.0 and xjc #7161) as soon as pdfbox/xmbox is fixed --> https://issues.apache.org/jira/browse/PDFBOX-5061, which is fixed now in PDFBox 3.0
• Entry window: Changing selected entry while editing the previous entry #5079 depends on https://bugs.openjdk.java.net/browse/JDK-8087910
• Mac OSX Drag and Drop does not recognize Modifier keys : https://bugs.openjdk.java.net/browse/JDK-8264172
• JDK-8246197: jlink with many modules fail duplicate of JDK-8240567
• JDK-8240567: MethodTooLargeException thrown while creating a jlink image: [ERROR] Error: jdk.internal.org.objectweb.asm.MethodTooLargeException: Method too large
• File locks on WSL: Cannot save library in WSL folder from Windows #9547

[Siedlerchr]

Method too large error:
if I understand this correct from the badass jlink docs, all non modular jars are merged together in a single module and thus require no entry in the java list of modules that is this method, that is throwing the method too large error.

The badass-jlink plugin takes a more pragmatic approach by combining all non-modular dependencies into a single jar. This way, only the resulting merged module needs a module descriptor.

https://badass-jlink-plugin.beryx.org/releases/latest/

[koppor]

Method too large error:

I was in the jlink code - I think, we need to work on that method. I think, we want to learn how to generate bytecode, don't we?

[Siedlerchr]

Handbook:
https://asm.ow2.io/asm4-guide.pdf

We would need to generate smaller methods and add references to these smaller methods then to the main module descriptor method

[Siedlerchr]

Method too large was fixed by us and is now integrated in JDK 21.0.1 as well
https://www.oracle.com/java/technologies/javase/21-0-1-relnotes.html