Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main table: Coloured group indicator for cited entries does not show up consistently anymore #6394

Closed
systemoperator opened this issue May 2, 2020 · 11 comments · Fixed by #7173
Assignees
Labels

Comments

@systemoperator
Copy link
Contributor

systemoperator commented May 2, 2020

Tested with the latest JabRef development version (master branch) on Ubuntu 16.04

Unfortunately, the colored group indicator for cited entries does not show up consistently anymore in the main table: The badge icon with the number of cited entries works, but the colored group indicator in the main table does not show up for most of the cited entries. Sometimes only one, two or four indicators show up. (Updating the group repeatedly or restarting JabRef does not help either.)

@tobiasdiez I strongly suspect that the cause of this issue is connected with the recently conducted performance optimizations of the group functionality (faster group calculations). When reverting back for two weeks, this problem vanishes.

Steps to reproduce the behavior:

  1. Create group of cited entries by linking the corresponding .aux file
  2. Cite entries in a tex file and build the pdf file
  3. Update group of cited entries
  4. Observation: Not all indicators show up
@tobiasdiez tobiasdiez added this to the v5.1 milestone May 2, 2020
@systemoperator
Copy link
Contributor Author

systemoperator commented May 13, 2020

The issue is caused by commit bc57d22.

@systemoperator
Copy link
Contributor Author

systemoperator commented Jun 18, 2020

#6586 slightly reduced the problem, since when the library gets reopened or JabRef gets restarted, then all groups are freshly parsed and properly created now, but the underlying problem still persists in all other cases.

@koppor koppor modified the milestones: v5.1, v5.2 Jul 27, 2020
@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

I'll start looking at this

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

k3KAW8Pnf7mkmdSMPHz27 commented Nov 18, 2020

Should an entry's group(s) always show in StandardField.GROUPS? I haven't been able to find any discussion regarding this topic.

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

k3KAW8Pnf7mkmdSMPHz27 commented Dec 16, 2020

What is the expected behaviour for when you have a group selected, so that only entries in the .aux file is shown, and a change occur so that an entry is added/removed?
I am ok with an entry not being removed from the view (as it is indicated by the group color anyway, as shown in the screenshot below), but what about when they are added?

Skärmavbild 2020-12-16 kl  14 35 40

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

I am assuming that it should behave in the same way as for searches (the bib entry gets added/removed immediately but the entry editor still show the entry if it was selected)

@koppor
Copy link
Member

koppor commented Dec 17, 2020

According to the documentation (at https://docs.jabref.org/finding-sorting-and-cleaning-entries/groups#using-the-cited-entries-of-a-latex-document), the .aux file is hot reloaded. Since the group changed, I would like to see all changes in the maintable, too. Which means: removal causes removal and addition causes addition. 😇

@koppor
Copy link
Member

koppor commented Dec 24, 2020

Removed from the milestone as we are going to release v5.2 today - and there is the PR #7173 opened working on fixing the issue.

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

Sorry about the delay, hopefully it means it gets "right" in the end!

@Siedlerchr
Copy link
Member

No problem, we just wanted to release today, no matter if it's done or not. Will probably create another release afterwards more soon

@tobiasdiez
Copy link
Member

tobiasdiez commented Jan 13, 2021

Thanks to @k3KAW8Pnf7mkmdSMPHz27 this should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants