Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to add an entry from zbmath.org via its zbMATH id #7202

Closed
ibe-314 opened this issue Dec 17, 2020 · 4 comments · Fixed by #7298
Closed

Add support to add an entry from zbmath.org via its zbMATH id #7202

ibe-314 opened this issue Dec 17, 2020 · 4 comments · Fixed by #7298

Comments

@ibe-314
Copy link
Contributor

ibe-314 commented Dec 17, 2020

JabRef supports adding entries via different kind of ids (https://docs.jabref.org/collect/add-entry-using-an-id). Right now, it is not possible to add an entry from zbmath.org via its zbMATH id, however it is possible to add entries by searching its database (https://docs.jabref.org/collect/import-using-online-bibliographic-database).

I would like to implement the possibility to add entries directly via their zbMATH id. I think this can be done quite easily by adjusting the zbMATH-Fetcher. I think this would be interesting as zbmath will become open access from January 2021 and thus no subscribtion for it is needed anymore.

@Siedlerchr
Copy link
Member

Siedlerchr commented Dec 19, 2020

Welcome! I think this will be a really cool thing for JabRef to have.
For getting started check out our contribution guide
The existing zbMath fetcher is here https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/logic/importer/fetcher/ZbMATH.java

You probably just need to implement the IDBasedFetcher /IdBasedParserFetcher interface to make it work.

We're looking forward for a PR from you :)

@ibe-314
Copy link
Contributor Author

ibe-314 commented Dec 19, 2020

Thank you for the information. I already had a look at the code and found the zbMath fetcher :-) I won't have that much time this year but I will work on the fetcher the first week of January.

@ibe-314
Copy link
Contributor Author

ibe-314 commented Jan 4, 2021

Hi,
I implemented the IdBasedParserFetcher interface for the zbmath fetcher and it worked on my Computer (with gradlew run.)
However, I have a problem testing jabref. Even on the master branch (without my changes) neither gradlew test nor gradlew check work. The "How to test" (https://devdocs.jabref.org/getting-into-the-code/testing) did not help me. What do I have to do in order to be able to test jabref?
Best
Isabel

@Siedlerchr
Copy link
Member

Hi, it should be fine to just run the specific test for the fetcher from your IDE.
The Github Actions automatically execute the tests when you create the PR, so you can see the results there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants