Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: "Export order" --> "Save order" #7517

Closed
mlep opened this issue Mar 12, 2021 · 9 comments · Fixed by #7518
Closed

UI: "Export order" --> "Save order" #7517

mlep opened this issue Mar 12, 2021 · 9 comments · Fixed by #7518

Comments

@mlep
Copy link
Contributor

mlep commented Mar 12, 2021

For JabRef 5.3--2021-03-11--8bb7668,
in Options -> Preferences, Tab File, there is a section entitled "Export sort order":
JabRef-Pref-SortOrder

Same in Library -> Library properties:
JabRef-Library-SortOrder

Is your suggestion for improvement related to a problem? Please describe.
Currently, these items do not affect the sort order when exporting entries (like using File -> Export).
They alter the sort order when saving the library.

Describe the solution you'd like
Make clear that these items affect the saving order by changing "Export [...]" into "Save [>...]"

@yinpeiqi yinpeiqi mentioned this issue Mar 12, 2021
5 tasks
@Siedlerchr
Copy link
Member

I took a deeper lok at the code, they are both the save order for the library and for the export.
The savePreferences contain the sort Order

List<BibEntry> sorted = BibDatabaseWriter.getSortedEntries(databaseContext, entries, savePreferences);

@Siedlerchr
Copy link
Member

I think I found a bug with regard to the export, theredfore I close this issue

@tobiasdiez
Copy link
Member

I would say "Save order" is still better since it then includes the normal file save as well as export. Maybe even make it very explicit and say "Save and export order"?

@mlep
Copy link
Contributor Author

mlep commented Mar 13, 2021

I second @tobiasdiez about "Save and export order"!

@tobiasdiez tobiasdiez reopened this Mar 14, 2021
@2bein
Copy link

2bein commented Mar 16, 2021

I would suggest to have separate options for saving the library and exporting (selected entries). The reason ist that I use SVN to follow changes of the libraray that is used by many members of our institute. Changing the save order always confuses the file versioning...

@koppor
Copy link
Member

koppor commented Mar 29, 2021

For me - complete screenshots to understand the issue

Export is correct:

grafik

Library properties incorrect:

grafik

@2bein
Copy link

2bein commented Apr 1, 2021

Yes, that would be perfect!

@Siedlerchr
Copy link
Member

Now merged. Please note that the latest branch is now called "main" instead of master

@mlep
Copy link
Contributor Author

mlep commented Apr 6, 2021

Works fine, great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants