Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo of cut and delete entries doesn't work #796

Closed
oscargus opened this issue Feb 11, 2016 · 8 comments
Closed

Undo of cut and delete entries doesn't work #796

oscargus opened this issue Feb 11, 2016 · 8 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Milestone

Comments

@oscargus
Copy link
Contributor

Somehow, only one entry is restored when undoing cut or delete of more than one entry. I thought I had messed it up in #793, but it behaved like this before merging it in...

@oscargus oscargus added the bug Confirmed bugs or reports that are very likely to be bugs label Feb 11, 2016
@oscargus oscargus added this to the v3.3 milestone Feb 11, 2016
@tobiasdiez
Copy link
Member

I can't replicate this bug. Can you please describe in more detail when this bug occurs (e.g. cut via context menu or normal menu, keybord shortcut,...).

@chriba
Copy link
Contributor

chriba commented Mar 2, 2016

When you delete 2 Entries on the same time and undo the action only one entry is recovered and an error is throw.
I'm working on a fix.

@oscargus
Copy link
Contributor Author

oscargus commented Mar 3, 2016 via email

@oscargus
Copy link
Contributor Author

oscargus commented Mar 4, 2016

I tried it now and it seems like it is working properly. I can at least not trigger anything. I think it was related to not returning a copy of the list of selected entries, so when starting to manipulate the entries, the list changed.

Unless someone else has a problem, I believe it can be closed.

@tobiasdiez
Copy link
Member

I close it now. If somebody experience the problem, then this issue can be reopened.

@chriba
Copy link
Contributor

chriba commented Mar 11, 2016

I still experience that bug.
tested with the current master at 7aa371c.

issue-796

@chriba
Copy link
Contributor

chriba commented May 12, 2016

This can now be closed!

@matthiasgeiger
Copy link
Member

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Development

No branches or pull requests

6 participants