Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search in dark theme: visual clues inverted #8026

Closed
2 tasks done
mlep opened this issue Aug 30, 2021 · 3 comments · Fixed by #8028
Closed
2 tasks done

Search in dark theme: visual clues inverted #8026

mlep opened this issue Aug 30, 2021 · 3 comments · Fixed by #8028

Comments

@mlep
Copy link
Contributor

mlep commented Aug 30, 2021

JabRef version

Latest development branch build (please note build date below)

Operating system

GNU / Linux

Details on version and operating system

JabRef 5.4--2021-08-23--cef4151 Linux 4.19.0-17-amd64 amd64 Java 16.0.2 JavaFX 16+8

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

A follow-up on issue #8014

  1. Open JabRef in dark mode
  2. Open the bib file https://github.com/JabRef/jabref/blob/main/src/test/resources/testbib/jabref-authors.bib
  3. Type alver in the search bar
  • if the abc icon is dark (which should mean "Not case sensitive), no results are found:
    ksnip_20210830-095000

  • if the abc icon is bright (which should mean "Case sensitive), results are found:
    ksnip_20210830-095056

The opposite behavior is expected.
Same (inverted) behavior observed for the Regular expressionicon (and likely for the Full text search icon).

Appendix

...

Log File ``` Paste an excerpt of your log file here ```
@mlep
Copy link
Contributor Author

mlep commented Aug 31, 2021

Indeed, fixed in JabRef 5.4--2021-08-31--df83c9d
Thank you @Siedlerchr!

@Siedlerchr
Copy link
Member

It was fortunately just a css/color problem. Thanks for the continous test and the feedback!

@mlep
Copy link
Contributor Author

mlep commented Aug 31, 2021

My pleasure to help enhancing a key software managed by a reactive team of programmers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants