Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Copy DOI URL' in entry list only copies DOI but not the URL #8389

Closed
2 tasks done
ytzemih opened this issue Jan 5, 2022 · 2 comments
Closed
2 tasks done

'Copy DOI URL' in entry list only copies DOI but not the URL #8389

ytzemih opened this issue Jan 5, 2022 · 2 comments
Labels
component: maintable good first issue An issue intended for project-newcomers. Varies in difficulty. [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs

Comments

@ytzemih
Copy link

ytzemih commented Jan 5, 2022

JabRef version

Latest development branch build (please note build date below)
JabRef 5.5--2022-01-03--c94bb1b
Linux 5.11.0-44-generic amd64
Java 16.0.2
JavaFX 17.0.1+1

Operating system

GNU / Linux

Details on version and operating system

Ubuntu 20.04

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. In the entry list, right-click on a URL symbol in the URL column and chose menu item "Copy ... -> Copy DOI URL"
  2. Paste from clipboard and you will only see the DOI pasted.
  3. Now, open that entry in the entry editor, go to "Optional fields", right-click on DOI and chose menu item "Copy DOI URL".
  4. Paste from clipboard and you will see the DOI URL pasted.
@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs labels Jan 7, 2022
@Siedlerchr
Copy link
Member

HI, welcome to JabRef! The first step is always trying to reproduce the issue.
Then to find the differences.
As a staring point, the MainTable code for copying is somewhere in org.jabref.gui.maintable.RightClickMenu
and the other one (for the field in the Entry Editor) And for the other one you should take a look in org.jabref.gui.fieldeditors.contextmenu.EditorMenus

When you have a fix follow the guide and create a new PR.

@Siedlerchr
Copy link
Member

I tested it and it works. For consistency reasons, I would also add the Copy DOI and Copy DOI Url context menu to the entry editor
grafik

@koppor koppor closed this as completed Jan 31, 2022
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: maintable good first issue An issue intended for project-newcomers. Varies in difficulty. [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs
Projects
Archived in project
Development

No branches or pull requests

2 participants