Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JabRef writes corrupted library files that can no longer be read, leading to dataloss #8484

Closed
2 tasks done
Tracked by #8750
mocherry opened this issue Feb 4, 2022 · 5 comments · Fixed by #9067
Closed
2 tasks done
Tracked by #8750
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs export / save
Milestone

Comments

@mocherry
Copy link

mocherry commented Feb 4, 2022

JabRef version

Latest development branch build (please note build date below)

Operating system

Windows

Details on version and operating system

Windows 10 10.0 amd64 Java 17.0.1 JavaFX 17.0.2-ea+3

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

When launching Jabref after installing, program freezes.
When launching as "Administrator" it at least starts

  1. Open library: selecting my saved library file, ...bib; then I get: "No content in table"

Appendix

Content of Event Log

.Fix SSL exceptions by accepting ALL certificates
Not updating theme because it hasn't changed
Theme set to Theme{type=DEFAULT, name=''} with base css StyleSheet{jrt:/org.jabref/org/jabref/gui/Base.css}
Index path for C:\111_mk\MOK\MOK\matthias.pdf\mkirsch_literature.bib is C:\Users\admin.kirsch.MOK2018\AppData\Local\org.jabref\JabRef\0.5a
Opening: 'C:\111_mk\MOK\MOK\matthias.pdf\mkirsch_literature.bib'

@Siedlerchr
Copy link
Member

HI, thanks for reporting this. Can you open the bib file with an editor e...g Notepad++ and check the encoding?
It might be that some encoding line is missing

@tobiasdiez tobiasdiez changed the title Jabref shows "No content in table" after abRef 5.6--2022-02-01--2614890 JabRef writes corrupted library files that can no longer be read, leading to dataloss Feb 7, 2022
@tobiasdiez tobiasdiez added export / save bug Confirmed bugs or reports that are very likely to be bugs labels Feb 7, 2022
@tobiasdiez tobiasdiez added this to the v6.0 milestone Feb 7, 2022
@tobiasdiez
Copy link
Member

I think something is seriously broken in the file writing algorithm in recent versions. I managed to corrupt my own library by exiting JabRef forcefully during the writing process. Also I have now constantly a sav.tmp file lying around.

Flagging this as devcall, to bring it up for eveyones attention and hopefully it will be fixed soon (maybe even with a hotfix release).

@koppor koppor self-assigned this Feb 18, 2022
@koppor
Copy link
Member

koppor commented Feb 18, 2022

Improved writing introduced at #8238

I will search for the place where an exception is thrown during writing. I will then try to continue writing at this point (and also try to write the exception to a File to allow easier debugging).

We did not change the .sav.tmp logic (yet). Relates to #6694.

@koppor koppor modified the milestones: v6.0, v5.6 Feb 18, 2022
@koppor
Copy link
Member

koppor commented Feb 19, 2022

@mocherry Could you send me your original bib file? My email address is available on my GitHub profile.

@calixtus
Copy link
Member

maybe fixed in #8506 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs export / save
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants