Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Duplicate check of keygenerator during merge dialogue after importing and pasting entry #8642

Closed
2 tasks done
ThiloteE opened this issue Apr 4, 2022 · 0 comments · Fixed by #8641
Closed
2 tasks done

Comments

@ThiloteE
Copy link
Member

ThiloteE commented Apr 4, 2022

JabRef version

Latest development branch build (please note build date below)

Operating system

Windows

Details on version and operating system

Jabref 5.6 version 4d8e41c

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

Follow up to #8361

Original comment: #8361 (comment)

Looking quite good! Solved 2 issues. 1 new issue pops up 😂 Hopefully the last one.

Bug3:

  1. Have options>preferenes>import and export>generate a new key for imported entries (overwriting their default) enabled.
  2. Have a customized key-pattern for the citation-key generator set in preferences.
  3. Have this preference set under citation-key generator preferences:
    image
  4. Import entry by ID into library5 OR paste entry5 by ID into library5. Let's call this one entry5.
  5. Import entry by ID into library5 OR paste entry5 by ID into library5 AGAIN. Let's call this one entry5².
    • Duplicate Merge Editor will emerge. So far so good.
  6. Click keep merged entry only

Result:

  • entry5² will get assigned citationkey-according-to-my-pattern+a

Expected result:

  • entry5² will get assigned citationkey-according-to-my-pattern

Additional info:

This becomes really weird when entry5 and entry5² are not exactly identical. E.g.

  • entry5: date = {2016}
  • entry5²: date = {2016-10-02}

My key pattern includes the date into the citation-key. Therefore,

key before merge: 2016
key after merge: 2016-10-02a, EVEN THOUGH 2016-10-02 would be unique in my library.

All the other buttons work and I have not noticed any other bugs so far.

Appendix

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant